PHP MySQL Insert Problem

Question

$dbHost = "localhost"; 
$dbUsr = "root"; 
$dbPass = "";

function register() { 
  $username = md5($_POST['username']); 
  $password = md5($_POST['password']); 
  $remote = md5($_SERVER['REMOTE_ADDR']);

  $connect = mysql_connect("$dbHost", "$dbUsr", "$dbPass");
  mysql_select_db("drupia1", $connect);

  $query = sprintf('INSERT INTO usrs
                      (username, password, ip)
                    VALUES
                      ("$username", "$password", "$remote"', mysql_real_escape_string($username), mysql_real_escape_string($password));
}

Why is it this script and any other way I write it, the values in mysql seem to be 0?

@ianace: The edit you propose corrects the issue/error the OP has -- your correction doesn't help the OP. — OMG Ponies
– OMG Ponies, Commented May 4, 2011 at 3:28

OMG Ponies · Accepted Answer · 2011-05-04 03:25:52Z

3

Consult php.net for using sprintf - it should resemble:

$query = sprintf("INSERT INTO usrs 
                    (username, password, ip) 
                  VALUES
                    ('%s', '%s', '%s' )", 
                  mysql_real_escape_string($username), 
                  mysql_real_escape_string($password),
                  $remote);

edited May 4, 2011 at 3:25

OMG Ponies

334k85 gold badges536 silver badges508 bronze badges

answered May 4, 2011 at 3:24

Ibu

44k14 gold badges82 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

helloandre Over a year ago

this is still missing the third %s which, presumably, is supposed to be remote.

Ibu Over a year ago

no it is ok now, you made correct changes it was the single quotes, Thanks @OMG

Collectives™ on Stack Overflow

PHP MySQL Insert Problem

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related