How to add event attribute to html tag with JavaScript

Question

I created some label tag with JavaScript something like this:

 var labelTag = document.createElement("label"); 
 labelTag.id = i; 
 labelTag.className ="myrows"; 
 labelTag.innerHTML = data[1];

It's ok, but I need to add onlick attribute to this label too.

So I need to look the result something like this:

  <label id='0' class='myrows' onclick=myfunction('first','second',..)> some info here</label>

I try with this: labelTag.onclick=myfunction('first',second,...);

No code error, but after I run the page on browser and see the source this attribute is missing. What's wrong?

can we try with jQuery??

xkeshav
– xkeshav

2011-05-04 10:30:03 +00:00
Commented May 4, 2011 at 10:30 — xkeshav
– xkeshav, Commented May 4, 2011 at 10:30

Felix Kling · Accepted Answer · 2011-05-04 10:30:49Z

3

This

labelTag.onclick = myfunction('first', 'second', ...);

assigns the return value of myfunction to labelTag.onclick.

You have to wrap it into an anonymous function if you want to pass parameters to the function:

labelTag.onclick = function() {
    myfunction('first', 'second', ...);
};

Note that you won't see any changes in the DOM if you inspect it.

For more information about event handling and the various ways to attach handlers, I recommend to read the excellent articles on quirksmode.org.

answered May 4, 2011 at 10:30

Felix Kling

820k181 gold badges1.1k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

holian Over a year ago

ehh...i tought it shown in the source, your comment is work well too, but that was the second one..so...thank you Master

Felix Kling Over a year ago

@holian: i tought it shown in the source I don't know that you mean with that. that was the second one And what do you mean with that?

Pav · Accepted Answer · 2011-05-04 10:34:05Z

1

var labelTag = document.createElement("label"); 
labelTag.id = i; 
labelTag.className ="myrows"; 
labelTag.innerHTML = data[1];
labelTag.onclick = function() {
   alert('Clicked');
};

answered May 4, 2011 at 10:34

Pav

2,3284 gold badges23 silver badges25 bronze badges

Collectives™ on Stack Overflow

How to add event attribute to html tag with JavaScript

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related