php if elseif statement problem

Question

I have a very simple php program that I am working on for my computer science class but I am having a little trouble with it.

<?php
$numOfCards = '50'; //$_POST['numOfCards'];
$totalCost = 0.00;

if (numOfCards == '20')
{
$totalCost = $numOfCards*3.00;
}
else if (numOfCards == '50')
{
$totalCost = $numOfCards*2.50;
}
else
{
$totalCost = $numOfCards*2.00;
}

echo "<p>TOTAL COST FOR ".$numOfCards." CARDS: $".$totalCost."</p>";
?>

As you can see, I was originally getting my $numOfCards value from post data but have set it to 50 to prove a point. The issue is that this code as it is should go to the else if statement but instead it is going to the else statement. This results in totalCosts equalling $100 instead of $125.

Does anyone know what I am doing wrong? Thanks

2 revs, 2 users 78% · Accepted Answer · 2011-05-04 15:30:41Z

5

You seem to have a $ missing in numOfCards twice.

To easier find these problems enable error reporting and warnings on top of your script:

error_reporting(-1);
ini_set('display_errors','On');

Then you will see two messages explaining that instead of comparing against a variable (as you wanted to) you compared against the string "numOfCards".

edited May 4, 2011 at 15:30

community wiki

2 revs, 2 users 78%
hakre

Sign up to request clarification or add additional context in comments.

3 Comments

mellamokb Over a year ago

Curious: What's the logic behind CW?

Pekka Over a year ago

@mellamokb I don't like that pointing out a missing $ gains so much reputation. I'm trying this out for questions that are either about a totally trivial manual link (background here) or a small typo

Clay Over a year ago

Thanks for all of the advice. I'm used to C# where simple errors like this would come up at compile time. I guess I'll have to pay more attention with php :(

ThiefMaster · Accepted Answer · 2011-05-04 15:27:07Z

2

You have to use $numOfCards instead of just numOfCards.

Additionally you should indent your code blocks, preferably with 4-spaces per level:

if ($numOfCards == '20') {
    $totalCost = $numOfCards*3.00;
}
else if ($numOfCards == '50') {
    $totalCost = $numOfCards*2.50;
}
else {
    $totalCost = $numOfCards*2.00;
}

answered May 4, 2011 at 15:27

ThiefMaster

320k85 gold badges608 silver badges648 bronze badges

Comments

mellamokb · Accepted Answer · 2011-05-04 15:26:32Z

0

It looks like you are missing the $ in the variable names.

if (**$**numOfCards == '20')

http://ideone.com/Y89nu

answered May 4, 2011 at 15:26

mellamokb

56.8k12 gold badges111 silver badges138 bronze badges

Comments

mario · Accepted Answer · 2011-05-04 22:24:21Z

-1

Yes you missed a $ sign

The code should be

$numOfCards = '50'; 
//$_POST['numOfCards']; 
$totalCost = 0.00;  

if ($numOfCards  == '20') 
{     
  $totalCost = $numOfCards*3.00;     
} 
else if ($numOfCards  == '50') 
{     
  $totalCost = $numOfCards*2.50;     
} 
else 
{     
  $totalCost = $numOfCards*2.00;     
}  

echo "<p>TOTAL COST FOR ".$numOfCards." CARDS: $".$totalCost."</p>";

edited May 4, 2011 at 22:24

mario

146k20 gold badges243 silver badges293 bronze badges

answered May 4, 2011 at 15:38

Syed Shah

11 bronze badge

Collectives™ on Stack Overflow

php if elseif statement problem

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related