mysql_fetch_array() timing out

Question

I am trying to query a database, but it seems to just load for an age and not do anything. It's a simple query and shouldnt take longer than a millisecond.

while($row = mysql_fetch_array(getWallPosts($userid)))
{
}

Now when I replace this code with:

echo mysql_num_rows(getWallPosts($userid));

It just displays '1' in fact there's only one record in the DB and it's just a simple SELECT statement.

Here's the getWallPosts function:

function getWallPosts($userid, $limit = "10")
{
    $result = dbquery("SELECT * FROM commentpost 
                           WHERE userID = ".$userid." 
                           ORDER BY commentPostID DESC LIMIT 0, ".$limit);
    return $result;
}

Also, when I put the SQL string that it's executing into MySQL's query browser. It takes no time at all.

Any ideas?

change $result = dbquery("SELECT * FROM commentpost WHERE userID = ".$userid." ORDER BY commentPostID DESC LIMIT 0, ".$limit); to $result = dbquery("SELECT * FROM commentpost WHERE userID = '".$userid."' ORDER BY commentPostID DESC LIMIT 0, ".$limit); otherwise you may suffer SQL-injection attacks (depending on where $userid came from, also note that if $limit comes from outside, there's NO WAY to protect against SQL-injection. If it's from inside you're safe — Johan
– Johan, Commented May 4, 2011 at 22:11

Joe Phillips · Accepted Answer · 2011-05-04 21:55:58Z

3

You appear to be looping indefinitely because you're retrieving a new set (one record) of data each time.

$result = getWallPosts($userid);

while ($row = mysql_fetch_array($result)) {
    //printf($row[0]);  
}

answered May 4, 2011 at 21:55

Joe Phillips

51.5k33 gold badges109 silver badges167 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Frank Farmer Over a year ago

+1. Try: $r = getWallPosts($userid); while($row = mysql_fetch_array($r)) {}

Pete Hamilton · Accepted Answer · 2011-05-04 21:57:14Z

1

You need to get the data once and loop through it. Your code is getting the data, running the loop and then getting the data again.

Try:

$posts = getWallPosts($userid);
while($row = mysql_fetch_array($posts))
{
  //Code to execute
}

answered May 4, 2011 at 21:57

Pete Hamilton

7,9607 gold badges36 silver badges59 bronze badges

Comments

Pete · Accepted Answer · 2011-05-04 21:57:18Z

0

Its an infinite loop. The expression in the while always executes so it will always be true.

answered May 4, 2011 at 21:57

Pete

10.9k10 gold badges56 silver badges75 bronze badges

Comments

Dan Breen · Accepted Answer · 2011-05-04 21:57:29Z

0

You're returning a new result set each time the while statement executes. You should call getWallPosts first, assign it to $results, and then loop over it.

answered May 4, 2011 at 21:57

Dan Breen

13k4 gold badges40 silver badges49 bronze badges

Collectives™ on Stack Overflow

mysql_fetch_array() timing out

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related