JavaScript forEach loop separating an array into other arrays using .push()

Question

New here and been trying to figure this out for a bit now. Can't seem to find the answer.

Problem: trying to separate all numbers from 5 upwards into a separate array "bigNumbers". All other numbers to "smallNumbers"

Here's what I have so far:

let allNumbers = [1, 2, 3, 4, 5, 6, 7, 8, 9]; 
let bigNumbers = []; 
let smallNumbers = [];

allNumbers.forEach(function (a) {
  if(allNumbers >= 5) {
    return allNumbers.push(bigNumbers);
  } else {
    return allNumbers.push(smallNumbers);
  }
});

Might be taking the wrong approach entirely here using the .push() method. Any feedback is appreciated.

Read the code.... Look at it closely First allNumbers >= 5 you are comparing an array to be greater than five. and then you have allNumbers.push(bigNumbers); You are pushing the bigNumbers array into the allNumbers array. You are not pushing a value into the array. Learn basic debugging console.log(allNumbers,5, allNumbers>=5) that will show you what is happening on the if. — epascarello
– epascarello, Commented Nov 26, 2019 at 17:34
try bigNumbers .push(a); and smallNumbers.push(a) instead. and check if (a >= 5) instead as well — TKoL
– TKoL, Commented Nov 26, 2019 at 17:35
Inside your .forEach() callback you should be referring to a, not allNumbers — Pointy
– Pointy, Commented Nov 26, 2019 at 17:35
Right return is pointless because .forEach() ignores return values. — Pointy
– Pointy, Commented Nov 26, 2019 at 17:36

Barmar · Accepted Answer · 2019-11-26 17:36:15Z

4

You're testing the wrong variable, it should be a, not allNumbers. And the argument to .push() is the value you want to push onto the array, not the array to push onto. There's also no need to use return, since forEach doesn't use the return values.

let allNumbers = [1, 2, 3, 4, 5, 6, 7, 8, 9]; 
let bigNumbers = []; 
let smallNumbers = [];

allNumbers.forEach(function (a) {
  if(a >= 5) {
     bigNumbers.push(a);
  } else {
     smallNumbers.push(a);
  }
});

console.log("Big: " + JSON.stringify(bigNumbers));
console.log("Small: " + JSON.stringify(smallNumbers));

answered Nov 26, 2019 at 17:36

Barmar

789k57 gold badges554 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jesús Franco · Accepted Answer · 2019-11-26 17:38:15Z

0

Trouble is in your if (allNumbers >= 5)

What you want is to know if the current number being iterated is greater than 5:

if (a >= 5)...

edited Nov 26, 2019 at 17:38

answered Nov 26, 2019 at 17:37

Jesús Franco

3264 silver badges12 bronze badges

2 Comments

Brandon Dyer Over a year ago

There are more problems than just the comparison.

Jesús Franco Over a year ago

Right, return is not necessary in forEach

Collectives™ on Stack Overflow

JavaScript forEach loop separating an array into other arrays using .push()

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related