Javascript - Insert onClick function dynamically

Question

My index.html

<div id="dropDownBolumDiv" class="dropdown-menu" x-placement="bottom-start" style="position: absolute; transform: translate3d(0px, 38px, 0px); top: 0px; left: 0px; will-change: transform;">

</div>

<script>
     var parameterYil = document.getElementById("dropDownYil1").value;
     var bolumler = ["ELEME MAKİNALARI", "ELEVATÖR", "EXCELL", "FOTOSORTER"];
     for (i = 0; i < bolumler.length; i++) {
         $("#dropDownBolumDiv").append("<a class='dropdown-item' onclick='refreshCharts(parameterYil,"+bolumler[i]+")'>" + bolumler[i] + "</a>");
     }
</script>

For example : when I clicked EXCELL,nothing happen.And console error says;

Uncaught ReferenceError: EXCELL is not defined at HTMLAnchorElement.onclick

What is problem ?

Dmitry Reutov · Accepted Answer · 2019-11-30 22:29:58Z

1

wrap bolumler's units in single quotes(') to make them string, not identifier

bolumler.forEach(v => {
         $("#dropDownBolumDiv").append(`<a class='dropdown-item' onclick='refreshCharts(parameterYil,"${v}")'>${v}</a>`);
     })

edited Nov 30, 2019 at 22:29

answered Nov 30, 2019 at 21:32

Dmitry Reutov

3,0321 gold badge9 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Hasan Kaan TURAN Over a year ago

I changed and result : <a class="dropdown-item" onclick="refreshCharts(2019," eleme makİnalari')'>ELEME MAKİNALARI</a> so dont work

Dmitry Reutov Over a year ago

Then just use not a single qoute but double qoutes with \ before it refreshCharts(parameterYil,\""+bolumler[i]+"\")

Dmitry Reutov Over a year ago

sorry, I changed my answer, i checked - this way it works

Hasan Kaan TURAN Over a year ago

don't work but no problem. I'll still mark it as an answer.Thank you..

Collectives™ on Stack Overflow

Javascript - Insert onClick function dynamically

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related