How to fix infinite while loop and create functions

Question

I am trying to make a paycheck program, that utilizes functions and while loops. In this program, I have to create two functions, one for validating the pay rate and hours, and then one for the calculations. In addition, I have to have the first function pass the hours and pay rate to the calculation function, and then pass it back to the first function. When I try to run the program with the first function, it seems that if I enter a pay amount under 7.25, it enters an infinite loop.

Here is the code

     <script>
    function payValidate(x)
    {
        if(isNaN(payRate) || payRate < 7.25 || payRate > 20)
        {
            return false;
        }
        else
        {
            return true;
        }
    }
    function hoursValidate(x)
    {
        if(isNaN(hours) || hours < 1 || hours > 60)
        {
            return false;
        }
        else
        {
            return true;
        }

}

    var grossPay;
    var withHolding;
    var netPay;
    var message;



var payRate = parseInt(prompt("Enter pay rate"));

var payRateOK = payValidate(payRate);
    while(!payRateOK)
    {
        payRate = parseInt(prompt("Invalid pay rate. Enter pay rate again"));
        payRateOk = payValidate(payRate);
    }
var hours = parseFloat(prompt("Enter hours worked"));
var hoursOK = hoursValidate(hours);

while(!hoursOK)
{
    hours = parseFloat(prompt("Invalid hours. Enter hours again"));
    hoursOK = hoursValidate(hours);
}

grossPay = payRate * hours;

    if(grossPay <= 300)
    {
        withHolding = grossPay * 0.10;
    }
    else
    {
        withHolding = grossPay * 0.12;
    }
    netPay = grossPay - withHolding;


    var message = "Pay Rate: $" + payRate.toFixed(2) +
    "\nHours Worked: " + hours +
    "\nGross Pay $" + grossPay.toFixed(2) +
    "\nWithholding $" + withHolding.toFixed(2) +
    "\nNet Pay $" + netPay.toFixed(2);

    alert(message);
</script>

Since you have floats inside payValidate(), you should replace parseInt() with parseFloat(). Also use "use strict" and you will find your issue. — Lain
– Lain, Commented Dec 1, 2019 at 18:26

KLP · Accepted Answer · 2019-12-01 18:27:34Z

1

You're creating a new variable payRateOk (notice the lower case k) instead of writing to payRateOK, the variable you check in the while loop. So payRateOK will never change, and the loop will execute infinitely.

answered Dec 1, 2019 at 18:27

KLP

4332 silver badges5 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kalana · Accepted Answer · 2019-12-01 18:45:06Z

0

var payRateOK = payValidate(payRate); // In here you have used "payRateOK"
while(!payRateOK)
{
   payRate = parseInt(prompt("Invalid pay rate. Enter pay rate again"));
   payRateOk = payValidate(payRate); // In here you have used "payRateok"
}

payRateOK != payRateOk there for you have to use same name for that
other thing is payRate is a float variable. you should use var payRate = parseFloat instead of var payRate = parseInt.
you have used hours as int type there for var hours = parseFloat should be var hours = parseInt

answered Dec 1, 2019 at 18:45

Kalana

4,4957 gold badges37 silver badges63 bronze badges

Collectives™ on Stack Overflow

How to fix infinite while loop and create functions

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related