what's wrong with my asp.net core controller method?

Question

In my asp.net core application, we are using the default MVC routing in App StartUp configuration.

Then in our controller, we have the following code for one of our api endpoint method:

  [HttpGet]
  [Route("services/task/{taskid?}/{taskmessage?}")]
  [Produces("text/html")]
  public async Task<ActionResult> TaskMessage(string taskId = null, string queue = null, string taskmessage = null)

Then we are trying to call the endpoint by passing taskmessage only as the following URL:
http://localhost:12345/api/services/task?taskmessage=hello

However, it's not working here. Can anyone please let me know where did I got wrong? It was working in our ASP.Net project, but once we migrated to the ASP.NET core, it's not working.

BTW, the version of ASP.NET core F/W we are currently using is ASP.NET Core 2.1, if it matters.

Hi @MattU, sorry I didn't make it clear. Not working here means in the URL I passed a value "hello" to the parameter "taskmessage", but in the method parameter, the "taskmessage" is still null. This is our issue. — CF7
– CF7, Commented Dec 3, 2019 at 2:14
I've not tried this in .Net Core. Instead, I use [FromQuery] for query string parameters. Like this: ([FromQuery] string taskMessage). You can use it for multiple parameters. And the template in the Route attribute is simpler. — Matt U
– Matt U, Commented Dec 3, 2019 at 2:46
Thanks @MattU I know we can use [FromQuery] for the query string parameters. But, from design perspective, I would like to know why is not bind in .Net Core. Why it's different with .Net... But, thank you anyway, I just tried with [FromQuery] and it's working for me — CF7
– CF7, Commented Dec 3, 2019 at 3:00
Also, it's probably better to use the HttpGet attribute and supply the route template there. [HttpGet("route/template")]. The [Route] attribute means the action will accept all HTTP verbs. learn.microsoft.com/en-us/aspnet/core/mvc/controllers/… ... See the green tip in that section. — Matt U
– Matt U, Commented Dec 3, 2019 at 3:01

Matt U · Accepted Answer · 2019-12-03 02:49:29Z

0

As this answer to a similar (but different) question states: Can't bind params using [FromQuery] ASP Net Core 2 API

[FromHeader], [FromQuery], [FromRoute], [FromForm]: Use these to specify the exact binding source you want to apply.

They referenced this link: https://learn.microsoft.com/en-us/aspnet/core/mvc/models/model-binding?view=aspnetcore-2.1 which talks about the various model binding methods.

answered Dec 3, 2019 at 2:49

Matt U

5,12812 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

what's wrong with my asp.net core controller method?

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related