How can I validate user input in simple way?

Question

I have the below function to validate the user input. Can you suggest whether it is OK or not? I just need simple way of validating user input. no need complex way.

function cleanData($data) {
    $data = trim($data);
    $data = htmlentities($data);
    $data = mysql_real_escape_string($data);
    return $data;
}

I use a php library validation class, do you consider that too complex? Really you'd need a boot strap file to run each time but apart from that, usage of the validation class, including to do custom validation, cleaning inputs etc becomes trivial — Jason
– Jason, Commented May 7, 2011 at 5:32
what you are expecting the data to be? i.e. integer, floating point etc etc. only accept data according to your expectation and reject the other. thats it in simply. — Khurram Ijaz
– Khurram Ijaz, Commented May 7, 2011 at 5:32
To VALIDATE means to do certain checks. For example, you could see if $data is within a certain number range or length. But what you're doing is more like 'cleaning up' the variable. Do you want to make it more specific? — itsols
– itsols, Commented May 7, 2011 at 5:33

mario · Accepted Answer · 2011-05-07 05:34:25Z

1

That's not a validation function. Your cleanData() function just escapes content. And it mixes HTML escaping with SQL escaping, where you should be applying each individually on a per use basis.

That approach is unprofessional, but in fact functional. (We've seen worse here). You do cover the common issues by using it. If you do in fact apply it to every incoming variable.

answered May 7, 2011 at 5:34

mario

146k20 gold badges243 silver badges293 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

itsols Over a year ago

Yep, well said. It in fact cleans the data and this is helpful to some extent in preventing against code/SQL injection, depending on of course, how it's going to be used.

Collectives™ on Stack Overflow

How can I validate user input in simple way?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related