JQuery click function not getting called

Question

I have a simple page for testing with only a button, I am linking to an external js file. It is displaying the jquery version in a alert box, but when the button is clicked nothing happens. What is wrong with this?

Here is my simple test html page

<title>Insert title here</title>
<!-- scripts -->
<script language="JavaScript" type="text/javascript" src="jquery.js"></script>
<script language="JavaScript" type="text/javascript" src="myscript.js"></script>
</head>
<body>
<form>
    <input  type="button"  tabindex="5"  value="jscript" id="testbutton" />
</form>
</body>

and here is my myscript file content

alert($.fn.jquery);
$('#testbutton').click(function(){
alert("test successful");
});

I am using JQuery version 1.6

karim79 · Accepted Answer · 2011-05-07 13:45:13Z

4

Probably because the DOM is not ready for JavaScript processing at the time of bindiing the click handler. Try:

$(document).ready(function() {
    $('#testbutton').click(function(){
        alert("test successful");
    });
});

answered May 7, 2011 at 13:45

karim79

343k67 gold badges420 silver badges409 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

karim79 Over a year ago

@Abhishek - Just to point out, I did answer first, but okay. (order the answers by oldest first) :)

AabinGunz Over a year ago

sorry i did not see the time. Thanks again!

user447356 Over a year ago

44 seconds makes all the difference! (+1 for both though) :)

Edgar Villegas Alvarado · Accepted Answer · 2011-05-07 13:45:57Z

1

You need a document.ready:

$(document).ready(function(){
  alert($.fn.jquery);
  $('#testbutton').click(function(){
    alert("test successful");
  });
});

That's because your #testbutton can't be referenced until it's loaded

Hope this helps. Cheers

answered May 7, 2011 at 13:45

Edgar Villegas Alvarado

18.4k2 gold badges45 silver badges61 bronze badges

2 Comments

AabinGunz Over a year ago

Thanks it worked. so this .ready() function is required at least once i suppose?

AabinGunz Over a year ago

Sorry Edgar, I did not see before but Karim79 answered my question 1st :)

Collectives™ on Stack Overflow

JQuery click function not getting called

2 Answers 2

3 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related