Create an array of objects for items greater than zero

Question

I need to create an array of objects for items greater than zero. I have the following code:

const payments = [];
if (values.ops > 0) {
  payments.push({
    "tax": options.find(item => item.value === "ops"),
    "type": ops.find(item => item.value === "tax"),
    "year": values.year,
    "period": ops.find(item => item.type === "period"),
    "sum": values.ops
  })
};
if (values.ops1 > 0) {
  payments.push({
    "tax": options.find(item => item.value === "ops1"),
    "type": ops1.find(item => item.value === "tax"),
    "year": values.year,
    "period": ops1.find(item => item.type === "period"),
    "sum": values.ops1
  })
};
if (values.oms > 0) {
  payments.push({
    "tax": options.find(item => item.value === "oms"),
    "type": oms.find(item => item.value === "tax"),
    "year": values.year,
    "period": oms.find(item => item.type === "period"),
    "sum": values.oms
  })
};

Is there any way to simplify this, so that I could check if an item is greater than 0 and make payments.push only once?

Could you please post an example for values variable? Thanks! — norbitrial
– norbitrial, Commented Dec 14, 2019 at 20:21

adiga · Accepted Answer · 2019-12-14 20:42:57Z

2

You could create a mapper object using Shorthand property names. This will map "ops" key with ops array as value and so on. Then loop through the entries of this object and push to the payments array based on values[key]

const mapper = {
  ops,
  ops1,
  oms
}

const payments = []

for (const [key, array] of Object.entries(mapper)) {
  if (values[key] > 0)
    payments.push({
      "tax": options.find(item => item.value === key),
      "type": array.find(item => item.value === "tax"),
      "year": values.year,
      "period": array.find(item => item.type === "period"),
      "sum": values[key]
    })
}

edited Dec 14, 2019 at 20:42

answered Dec 14, 2019 at 20:29

adiga

35.4k9 gold badges65 silver badges88 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bakhtiiar Muzakparov · Accepted Answer · 2019-12-14 20:27:39Z

0

const payments = [];

[
  "ops", 
  "ops1", 
  "oms"
].forEach(prop=>{
    if(values[props]>0){
        payments;.push({
            tax: options.find(item => item.value === prop),
            type: ops.find(item => item.value === "tax"),
            year: values.year,
            period: ops.find(item => item.type === "period"),
            sum: values[prop]
        })
    }
})

answered Dec 14, 2019 at 20:27

Bakhtiiar Muzakparov

2,4482 gold badges17 silver badges24 bronze badges

1 Comment

adiga Over a year ago

for type and period, the ops array is not fixed

Nina Scholz · Accepted Answer · 2019-12-14 20:29:17Z

0

You could take an object for ops, ops1 and oms and iterate the keys and oush new objects if necessary.

data = { ops, ops1, oms }

Object.keys(data).forEach(k => {
    if (values[k] <= 0) return;
    payments.push({
        tax: options.find(item => item.value === k),
        type: data[k].find(item => item.value === "tax"),
        year: values.year,
        period: data[k].find(item => item.type === "period"),
        sum: values[k]
    });
});

answered Dec 14, 2019 at 20:29

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Collectives™ on Stack Overflow

Create an array of objects for items greater than zero

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related