Java JSON unit test pass with wrong value

Question

I have the following function:

public class NorthboundApiLogicTest {

  @Test
  public void testIfParametersValuesAreCorrect() {
    String body = "{\"exception\":\"world\",\"error\":\"Not Found\",\"message\":\"hello\""
        + ",\"timestamp\":\"2020-01-07T12:26:48.334386Z\",\"status\":\"404\"}";
    try {
      JSONAssert.assertEquals("{message:hello, exception:world, status:403, error:Not Found}", 
          body, false);
    } catch (Exception e) {
      System.err.println(e);
    }
    System.out.println(body);
  }
}

I run this test with Maven, and strangely it pass successfully.

However, it should not, because I assert that status=403 but the value is 404. What am I doing wrong?

Note that JSONException thrown and you're in catch.

HieuHT
– HieuHT

2020-01-07 12:42:03 +00:00
Commented Jan 7, 2020 at 12:42 — HieuHT
– HieuHT, Commented Jan 7, 2020 at 12:42

Brian Agnew · Accepted Answer · 2020-01-07 12:41:19Z

4

It's failing to parse the JSON before it even performs an assertion on the structure, and you're simply logging that via your catch.

catch (Exception e) {
      System.err.println(e);
}

You need to let that exception be thrown from the method, or catch it and call fail() with an appropriate message.

And then fix the issue of your non-parseable JSON, of course!

answered Jan 7, 2020 at 12:41

Brian Agnew

273k38 gold badges342 silver badges443 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Nakrule Over a year ago

Strange because according to this jsonlint.com my JSON is valid.

bambula Over a year ago

{message:hello, exception:world, status:403, error:Not Found} is not valid json

Collectives™ on Stack Overflow

Java JSON unit test pass with wrong value

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related