Ruby on Rails Database Query with Ruby Variable

Question

This is the current code for my query..

<% property_id = params[:property] %>
<%= property_name = Hotel.find_by_sql('
        SELECT name 
        FROM hotels
    ') %>

I want to be able to add something like

WHERE hotel_id == property_id

But everything I try doesn't seem to work due to the "property_id" portion. I've tried concatenating, different assignments, etc. I feel dumb. SOS. Thank you ahead of time.

Also, when I add..

WHERE hotel_id == "hotelid1"

Which "hotelid1" is an existing hotel_id in the table. It works but not how I would imagine. It returns..

"[#Hotel id: nil, name: "HotelOne">]"

I'm wanting it to only output the hotel name. In this case, HotelOne.

Are you using Rails? Are you using Active Record? Why not just Hotel.find_by(hotel_id: hotel_id).name if you have the hotel_id available somewhere? Also, better in your case to move that query from your view. — Sebastián Palma
– Sebastián Palma, Commented Jan 13, 2020 at 6:32

Prabakaran · Accepted Answer · 2020-01-13 09:58:40Z

1

ActiveRecord's where should be suffice for you.

property_names = Hotel.where(hotel_id: params[:property]).pluck(:name)

And it's confusing to have hotel_id in Hotel model as it contradicts with the default id attribute. Anyhow hope this was useful to you.

Note: If hotel_id is unique in your table then better to go with @SebastianPalma's comment in your question.

edited Jan 13, 2020 at 9:58

answered Jan 13, 2020 at 8:34

Prabakaran

3532 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Prabakaran Over a year ago

@SebastianPalma - Oh yeah, in this case there is no need to :select. Thanks! Edited the answer.

Haha Over a year ago

I wish my upvotes actually counted so I could show my gratitude, this answer was extremely helpful. Thank you @Prabakaran

Sebastián Palma Over a year ago

Actually, due to your points, your upvotes are just going to be saved as a draft until you get the needed ones to persist them. If this answer helped you to solve your problems, you should accept it. This shows future readers that this answer solves the problem stated in the question.

ARK Over a year ago

Actually @SebastianPalma your comment is THE answer and I would suggest posting it as the answer but as OP got help from this answer too so it's his preference to accept any answer :)

Haha Over a year ago

@SebastianPalma thank you for the tip. I accepted the answer.

MD Tawab Alam Khan · Accepted Answer · 2020-01-13 07:40:21Z

0

I think you are looking for this.

<%= property_name = Hotel.find_by_sql("SELECT name FROM hotels WHERE hotel_id=#{ruby_variable}") %>

answered Jan 13, 2020 at 7:40

MD Tawab Alam Khan

18811 bronze badges

1 Comment

ARK Over a year ago

I upvoted to cancel the downvote and you get 8 extra reputation. There you go. And yeah I know it works but @Sebastian Palma's answer is rails-oriented and better.

Ankur Shukla · Accepted Answer · 2020-01-13 07:58:24Z

0

Try the below line :-

<% property_name = ActiveRecord::Base.connection.execute("SELECT name FROM hotels WHERE hotel_id=#{property_id}").first["name"] %>

answered Jan 13, 2020 at 7:58

Ankur Shukla

3652 silver badges9 bronze badges

3 Comments

Ankur Shukla Over a year ago

Whoever has downvoted this answer, for his information, this code gives exact answer as expected, as required and asked in the question. The person downvoting it is has no sense of RoR

ARK Over a year ago

I upvoted to cancel the downvote and you get 8 extra reputation. There you go. And yeah I know it works but @Sebastian Palma's answer is rails-oriented and better.

Sebastián Palma Over a year ago

And what's that line supposed to do @AnkurShukla?

Collectives™ on Stack Overflow

Ruby on Rails Database Query with Ruby Variable

3 Answers 3

5 Comments

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related