Inline JavaScript function within PHP Tag

Question

I am running this code in a PHP file

<?php
if(empty($item)){
    echo "Your cart is empty";
 }
 else{
    echo '<table id="cart_table"><tr><th>Item</th><th>Price</th><th></th></tr>' ;
         for($i = 0;$i< count($item);$i++){
             if(!empty($item[$i])){    
                 $numRow++; 
                 echo '<tr><td>' . "<img src = 'images/$photo[$i].jpg'>" .'</td>';
                 echo '<td>' .'$' . $item[$i] . '</td>'; 
                 echo '<td>' . '<button id= "btn"   onclick = "function(){
                    <script type="text/javascript">
                    document.getElementById("cart_table").deleteRow('. $numRow .');
                 }"> Remove</button>'.'</tr>' ;   
                }        
         }
         echo '</table>';
         }

 ?>

Please consider these lines of code only from the above snippet:

echo '<td>' . '<button id= "btn"   onclick = "function(){
       <script type="text/javascript">
       document.getElementById("cart_table").deleteRow('. $numRow .');
       }"> Remove</button>'.'</tr>' ;   
     }

The result of this code is:

The result I am trying to achieve is:

Is it possible to achieve this result? The result is going to be a button with the label "Remove" and with the onClick property that calls a INLINE(I know it's bad practice, but I have a good reason for it) function which executes some lines of code.

This is not even a PHP problem, you are just creating HTML that makes no sense. What business does <script type="text/javascript"> haven being inside an onclick attribute? Absolutely zero. — 04FS
– 04FS, Commented Jan 17, 2020 at 7:47
@mplungjan Thank you for the help, unfortunately that will not execute any JavaScript command though. — Fabrizio Botalla
– Fabrizio Botalla, Commented Jan 17, 2020 at 7:54
Even if you fix the markup, the logic is flawed. The index of the rows are going to shift after deleting one, so it is merely going to work correctly the first time. — Lain
– Lain, Commented Jan 17, 2020 at 7:55
I know that, my question is not regarding the logic. That will get changed. I am just asking if it is possible to have it all inline. Thanks though — Fabrizio Botalla
– Fabrizio Botalla, Commented Jan 17, 2020 at 7:59
onclick = "this.parentNode.parentNode.parentNode.removeChild(this.parentNode.parentNode)" — Lain
– Lain, Commented Jan 17, 2020 at 12:57

Not A Robot · Accepted Answer · 2020-01-17 11:01:44Z

1

Try not to mix up HTML and PHP together, if there is a need to mix HTML and PHP, try in proper formatting.

<?php
    if(empty($item)):
?>
         <span>Your cart is empty</span>
<?php
    else:
?>
        <table id="cart_table">
            <tr>
                <th>Item</th>
                <th>Price</th>
                <th></th>
            </tr>
            <?php
                for($i = 0;$i< count($item);$i++):
                    if(!empty($item[$i])):
                        $numRow++; 
            ?>
                        <tr>
                            <td><img src ='images/<?php echo $photo[$i].jpg; ?>'/></td>
                            <td>$<?php echo $item[$i]; ?></td> 
                            <td><button id= "btn" onclick = "deleteFromCart('<?php echo $numRow; ?>')"> Remove</button></td>
                        </tr>
            <?php
                    endif;
                endfor;
            ?>   
        </table>
<?php
    endif;
?>
 <script>
    function deleteFromCart(rowToDelete){
        document.getElementById("cart_table").deleteRow(rowToDelete);
    }
 </script>

edited Jan 17, 2020 at 11:01

answered Jan 17, 2020 at 8:01

Not A Robot

2,7002 gold badges20 silver badges37 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Fabrizio Botalla Over a year ago

Thank you for the suggestion! Like I asked in my question I need the suggestions to be inline, thank you though!

mplungjan Over a year ago

Still missing the </td> here too

Collectives™ on Stack Overflow

Inline JavaScript function within PHP Tag

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related