C# BinaryWriter/BinaryReader - Reader order doesn't match write order

Question

I have some voxel data I would like to save using BinaryWriter and then read using BinaryReader but I'm encountering some issues.

When I read it again, it seems like the data is in a different order and thus, my resulting voxel chunks get the wrong values. As I understood it you have to read the data in the order you wrote it, which I should be doing.
I've looked at several examples but and they all lead me to this issue. I don't know what I'm doing wrong.

I created some test code here to first write to a file and then read it right afterward and then check to see if the loaded values match the values it saveD. The result is always that it doesn't match and it always stops at the same place.

Block[] blocksToSave = chunk.blocks.GetBlocks();

using (BinaryWriter writer = new BinaryWriter(File.Open(Application.persistentDataPath + "/test.bin", FileMode.OpenOrCreate)))
{
    for (int i = 0; i < blocksToSave.Length; i++)
    {
        writer.Write(blocksToSave[i].id); // The ID is just a byte value.
    }
}

byte[] loadedBlocks = new byte[Chunk.CHUNK_SIZE * Chunk.CHUNK_SIZE * Chunk.CHUNK_SIZE]; // 16 * 16 * 16
using (BinaryReader reader = new BinaryReader(File.Open(Application.persistentDataPath + "/test.bin", FileMode.Open)))
{
    int pos = 0;
    int index = 0;
    int streamLength = (int)reader.BaseStream.Length;

    while (pos < streamLength)
    {
        byte id = reader.ReadByte();
        loadedBlocks[index] = id;
        pos += sizeof(int);
        index++;
    }
}

if (blocksToSave.Length != loadedBlocks.Length)
{
    Debug.LogError("Sizes does not match!");
    return;
}

for (int i = 0; i < blocksToSave.Length; i++)
{
    if (blocksToSave[i].id != loadedBlocks[i])
    {
        Debug.LogError("Expected " + blocksToSave[i].id + " but got " + loadedBlocks[i] + " at index " + i + ".");
        return;
    }
}

Any help to understand what the issue is greatly appreciated!
Thanks

sizeof(int) is 4 (bytes), but you're reading bytes - is that intentional? — C.Evenhuis
– C.Evenhuis, Commented Jan 24, 2020 at 21:38
@C.Evenhuis I'm so incredibly blind. I was working with ints before, changed it to bytes and then I guess I forgot I was working with bytes. Thanks for pointing it out. — Hertzole
– Hertzole, Commented Jan 24, 2020 at 22:12

NotTheBatman · Accepted Answer · 2020-01-24 21:39:59Z

3

pos += sizeof(int);

should be

pos += sizeof(byte);

answered Jan 24, 2020 at 21:39

NotTheBatman

1326 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Hertzole Over a year ago

Turns out I'm just blind. I had been using ints before, switched to bytes, forgot to change my saving and didn't think about that I was using bytes. Thank you.

Collectives™ on Stack Overflow

C# BinaryWriter/BinaryReader - Reader order doesn't match write order

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related