Array of observables angular rxjs

Question

I have following code:

export class GetPersonsService {
  url="https://swapi.co/api/people/";
  personsObservables;
  headers: HttpHeaders = new HttpHeaders()
    .set('Accept', 'application/json');
  constructor(private http:HttpClient) { }
  getPerson(personIndex){
    return this.http.get<Person>(`${this.url}${personIndex}`,{headers:this.headers});
  }
  getPersons(){
    for(let i=0;i<10;i++){
      this.personsObservables.push(this.getPerson(i));
    }
    console.log(this.personsObservables);
    return forkJoin(this.personsObservables);
  }
}

and I don't understand why this.personsObservables is undefined because If I invoke getPerson(1) I am getting observable.And the next question how to maintain api if there are 10/100 or more items and I want to detect how many are them.

You have to subscribe. You want to do asynchronous data as synchronously. — Kamil Augustyniak
– Kamil Augustyniak, Commented Feb 1, 2020 at 18:49
set '[]' on init: personsObservables = []; it'll remove undefined error — Kamil Augustyniak
– Kamil Augustyniak, Commented Feb 1, 2020 at 19:06
I've read incorrect your question I meant that when you use getPersons() method you have to do something like: getPersons().subscribe() — Kamil Augustyniak
– Kamil Augustyniak, Commented Feb 1, 2020 at 19:07

StepUp · Accepted Answer · 2020-02-01 19:52:10Z

It is necessary:

at first to initialize an array of url to avoid undefined error
then await API call getPerson(i)`
then you can use forkJoin.

So the code should look like this:

const personsObservables = [];

async getPersons(){
    for(let i=0;i<10;i++){
        this.personsObservables.push(await this.getPerson(i));
    }
    console.log(this.personsObservables);
    return forkJoin(this.personsObservables);
}

Let me show an example:

const request1 = this.http.get('https://restcountries.eu/rest/v1/name/india');
const request2 = this.http.get('https://restcountries.eu/rest/v1/name/us');
const request3 = this.http.get('https://restcountries.eu/rest/v1/name/ame');
const request4 = this.http.get('https://restcountries.eu/rest/v1/name/ja');

const requestArray = [];
requestArray.push(request1);
requestArray.push(request2);
requestArray.push(request3);
requestArray.push(request4);

forkJoin(requestArray).subscribe(results => {
  console.log(results);
  this.response = results;
});

All results are ordered accordingly pushed items into requestArray. It can be seen in a stackblitz example.

Binara Thambugala · Accepted Answer · 2020-02-01 20:17:40Z

0

Please do as below.

export class GetPersonsService {
  headers: HttpHeaders = new HttpHeaders().set("Accept", "application/json");
  url = "https://swapi.co/api/people/";
  personsObservables: Person[] = [];

  constructor(private http: HttpClient) {}

  getPerson(personIndex: number) {
    this.http
      .get<Person>(`${this.url}${personIndex}`, { headers: this.headers })
      .subscribe(data => {
        this.personsObservables.push(data);
      });
  }

  getPersons() {
    for (let i = 0; i < 10; i++) {
      this.getPerson(i);
    }
    console.log(this.personsObservables);
  }
}

answered Feb 1, 2020 at 20:17

Binara Thambugala

7866 silver badges17 bronze badges

Collectives™ on Stack Overflow

Array of observables angular rxjs

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related