Having trouble displaying my number using javascript

Question

I have to convert from decimal to binary and it requires at least 3 functions and it has to be displayed in HTML. This is what I've got so far and can't figure out how to make it display properly?

// Prompt user for number between 1-1000
let input = parseInt(prompt("Enter a number between 1 and 1000", "50"));

function store() {
let quotient = [];
let answer = quotient.reverse();
return answer;
}
function check() {
    while (input != 0) {
        if (input < 1000 && input % 2 != 0) {
            return quotient.push("1");
            input = input / 2;
        }
        else if (input < 1000 && input % 2 == 0) {
            return quotient.push("0");
            input = input / 2;
        }
    }
}
function display() {
    document.getElementById("displayNumber").innerHTML = answer;
}
display();

<h1 id="displayNumber"></h1>

Savin · Accepted Answer · 2020-02-14 05:09:32Z

1

Here is the fixed script, I hope this helps.

   function check(input, quotient) {
       while (input != 0) {
        if (input < 1000 && input % 2 != 0) {
            quotient.push("1");
            input = parseInt(input / 2);
        }else if (input < 1000 && input % 2 == 0) {
            quotient.push("0");
            input = parseInt(input / 2);
        }
    }
}

function display() {
    let input = parseInt(prompt("Enter a number between 1 and 1000", "50"));
    let quotient = [];
    check(input, quotient);
    let answer = quotient.reverse().join('');
    document.getElementById("displayNumber").innerHTML = answer;
}
display();

answered Feb 14, 2020 at 5:09

Savin

1315 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jacob · Accepted Answer · 2020-02-14 04:43:15Z

0

Currently, you are just creating the function store and check but not actually calling them.

However, if all you are wanting to do is to display the input as binary, you can use the toString function, passing in the base you desire.

Im not sure what you want to display if the number is outside of the range 1-1000. So I just put "Invalid input". You can add some more checks for if it is NAN ect

 <!DOCTYPE html>
 <html>

   <h1 id="displayNumber"></h1>
   <script>
     // Prompt user for number between 1-1000
     let input = parseInt(prompt("Enter a number between 1 and 1000", "50"));
     
     function display() {
       if (input < 1 || input > 1000) {
         document.getElementById("displayNumber").innerHTML = "Invalid input";
       } else {
         document.getElementById("displayNumber").innerHTML = input.toString(2);
       }
     }

     display();

   </script>
 </html>

answered Feb 14, 2020 at 4:43

Jacob

9262 gold badges8 silver badges19 bronze badges

1 Comment

Tak Over a year ago

if I want to make use of the other functions, how should I go about doing it?

Gulshan S · Accepted Answer · 2020-02-14 05:00:14Z

0

Here is updated snippet :

		function check(input) {
  	let quotient = [];
             while (input != 0) {
                 if (input < 1000 && input % 2 != 0) {
                     input = input / 2;
                 }
                 else if (input < 1000 && input % 2 == 0) {
                     input = input / 2;
                 }

                   quotient.push(input);
             }
             return quotient;

         }
 
         function display() {
             let input = parseInt(prompt("Enter a number between 1 and 1000", "50"));
             var answer = check(input);
             document.getElementById("displayNumber").innerHTML = answer;         

        }          
        display();

 <h1 id="displayNumber"></h1>

answered Feb 14, 2020 at 5:00

Gulshan S

1,1142 gold badges9 silver badges29 bronze badges

2 Comments

Tak Over a year ago

If i wanted to add one more function, could I make it so I have a function with the array? How would I call it from there though?

Gulshan S Over a year ago

You can make numbers of functions if you can and added as per requirements

Bharat Vats · Accepted Answer · 2020-02-14 05:19:56Z

In display function, you are assigning answer to innerHTML but not calling your check function.

<html> 
    <h1 id="displayNumber"></h1>
    <script>
        let input = parseInt(prompt('Enter a number between 1 and 1000', '50'));
        function check(input) {
            let quotient = [];
            while (input > 0) {
                quotient.push(input % 2);
                input = parseInt(input / 2);
            }
            return quotient.reverse().join('');
        }

        function display() {
            if (input >= 1 && input <= 1000) {
                document.getElementById("displayNumber").innerHTML = check(input);
            }
        }

    display();

</script>
</html>

Collectives™ on Stack Overflow

Having trouble displaying my number using javascript

4 Answers 4

Comments

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related