Problem with SqlConnection, ASP.net C#

Question

I have the following C# code:

public string TargetDate()
{
    SqlConnection con = 
        new SqlConnection("Server=localhost;Database=Timer;Trusted_Connectopn=True");
    SqlCommand cmd = new SqlCommand("select * from Timer");
    con.Open(); 

    DataSet ds = new DataSet(cmd,con); 
    SqlDataAdapter da = new SqlDataAdapter(); 
    da.Fill(ds); 
    con.Close(); 
}

but I get error at the: new DataSet(cmd,con); ...

the error: CS1502: The best overloaded method match for
'System.Data.DataSet.DataSet(System.Runtime.Serialization.SerializationInfo,
System.Runtime.Serialization.StreamingContext)' has some invalid arguments

What is could be the problem?

Hi, the connection string should be "Server=localhost;Database=Timer;Trusted_Connection=True". Thanks. — Vaibhav
– Vaibhav, Commented May 17, 2011 at 7:10
You can also try the documentation on MSDN, Populating a DataSet from a DataAdapter — aweis
– aweis, Commented May 17, 2011 at 7:12

Alex Aza · Accepted Answer · 2011-05-25 18:57:21Z

5

Try this:

SqlConnection con = new SqlConnection
    ("Server=localhost;Database=Timer;Trusted_Connection=True");

SqlCommand cmd = new SqlCommand("select * from Timer", con);

con.Open();

DataSet ds = new DataSet();
SqlDataAdapter da = new SqlDataAdapter(cmd);
da.Fill(ds);

con.Close();

This is even better:

DataTable dataTable = new DataTable();
using(SqlConnection connection = new SqlConnection("Server=localhost;Database=Timer;Trusted_Connection=True"))
using(SqlCommand command = connection.CreateCommand())
{
    command.CommandText = "select * from Timer";
    connection.Open();
    SqlDataReader reader = command.ExecuteReader();
    dataTable.Load(reader);
}

edited May 25, 2011 at 18:57

answered May 17, 2011 at 7:11

Alex Aza

78.8k26 gold badges157 silver badges134 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Menahem Over a year ago

does using CommandBehavior.CloseConnection in ExecuteReader make a difference ?

marc_s Over a year ago

Plus: fix the typo Trusted_Connection=True instead of Trusted_Connectopn=True

marc_s Over a year ago

+1 for the using....... blocks! And even better yet: don't use SELECT * but explicitly specify the columns that you really need...

tobias86 · Accepted Answer · 2011-05-17 07:26:14Z

4

You've got the wrong constructor for the DataSet. Try this

DataSet ds = new DataSet();
SqlDataAdapter da = new SqlDataAdapter(con);

edited May 17, 2011 at 7:26

answered May 17, 2011 at 7:11

tobias86

5,0291 gold badge23 silver badges31 bronze badges

3 Comments

Alex Aza Over a year ago

Is there a SqlDataAdapter constructor that takes SqlCommand and SqlConnection?

tobias86 Over a year ago

@Alex: Ah I see, I confused the string "selectCommandText" with the SqlCommand object. You are right.

V4Vendetta Over a year ago

Wow 3 upvotes for something inconsistent ! i believe you should clarify that cmd is a string and not a command object

Vaibhav · Accepted Answer · 2011-05-17 08:05:10Z

0

It seems you have mixed up the constructors:

Try the following:

DataSet ds = new DataSet(); 

SqlDataAdapter da = new SqlDataAdapter(con);

Hope that helps

edited May 17, 2011 at 8:05

answered May 17, 2011 at 7:11

Vaibhav

1,1662 gold badges13 silver badges27 bronze badges

1 Comment

Alex Aza Over a year ago

Is there a SqlDataAdapter constructor that takes SqlCommand and SqlConnection?

Collectives™ on Stack Overflow

Problem with SqlConnection, ASP.net C#

3 Answers 3

3 Comments

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related