String into multiple string in an array

Question

I have not been coding for long and ran into my first issue I just can not seem to figure out.

I have a string "XX|Y1234$ZT|QW4567" I need to remove both $ and | and push it into an array like this ['XX', 'Y1234', 'ZT', 'QW4567'].

I have tried using .replace and .split in every way I could like of

 var array = "XX|Y1234$ZT|QW4567"
 var array2 = [];

 array = array.split("$");

 for(i = o; i <array.length; i++)    
   var loopedArray = array[i].split("|")
   loopedArray.push(array2);        
 }

I have tried several other things but would take me awhile to put them all down.

take care with your code, your for loop doesn't have a { (opening brace) but have a } (closing brace) this will cause issues. also i = o didn't you mean var i = 0 ? Also, array2 is an empty array that you never modify, there's no logic in pushing it inside loopedArray — Calvin Nunes
– Calvin Nunes, Commented Feb 21, 2020 at 21:28

LMulvey · Accepted Answer · 2020-02-21 21:27:29Z

3

You can pass Regex into .split(). https://regexr.com/ is a great tool for messing with Regex.

// Below line returns this array ["XX", "Y1234", "ZT", "QW4567"]
// Splits by $ and |
"XX|Y1234$ZT|QW4567".split(/\$|\|/g);

answered Feb 21, 2020 at 21:27

LMulvey

1,67810 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Yevhen Horbunkov Over a year ago

I guess, .split(/[\$\|]/g) scales more nicely, when there're lot of delimiters, however upvoted

andred Over a year ago

@YevgenGorbunkov Tipp: You don't even have to escape | and $ inside a character class. And as we're not operating the regex to match blocks by itself, the g-match-all-flag isn't needed too. .split(/[|$]/) should be enough. But i'm with you about your initial statement: This should be faster.

junvar · Accepted Answer · 2020-02-21 22:54:11Z

1

Your code snippet is close, but you've messed up your variables in the push statement.

var array = "XX|Y1234$ZT|QW4567"
var array2 = [];

array = array.split("$");

for (i = 0; i < array.length; i++) {
  var loopedArray = array[i].split("|")
  array2.push(loopedArray);
}
array2 = array2.flat();

console.log(array2);

However, this can be rewritten much cleaner using flatMap. Also note the use of let instead of var and single quotes ' instead of double quotes ".

let array = 'XX|Y1234$ZT|QW4567'
let array2 = array
  .split('$')
  .flatMap(arrayI => arrayI.split('|'));

console.log(array2);

And lastly, split already supports multiple delimiters when using regex:

let array = 'XX|Y1234$ZT|QW4567'
let array2 = array.split(/[$|]/);

console.log(array2);

edited Feb 21, 2020 at 22:54

answered Feb 21, 2020 at 21:31

junvar

11.6k2 gold badges35 silver badges52 bronze badges

Comments

jmarceli · Accepted Answer · 2020-02-21 21:28:05Z

0

You can do this as follows:

"XX|Y1234$ZT|QW4567".replace('$','|').split('|')

It will produce the output of:

["XX", "Y1234", "ZT", "QW4567"]

answered Feb 21, 2020 at 21:28

jmarceli

20.3k6 gold badges73 silver badges69 bronze badges

1 Comment

logan Over a year ago

worked great. thats a simple great answer thank you for the help.

Changer · Accepted Answer · 2020-02-21 21:46:40Z

0

If you call the split with two parameters | and the $ you will get an strong array which is splittend by the given characters.

var array = "XX|Y1234$ZT|QW4567";
var splittedStrings = array.Split('|','$');
foreach(var singelString in splittedStrings){
   Console.WriteLine(singleString);
}

the output is:

XX
Y1234
ZT
QW4567

answered Feb 21, 2020 at 21:46

Changer

952 silver badges11 bronze badges

Collectives™ on Stack Overflow

String into multiple string in an array

4 Answers 4

2 Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related