Print array of reversed strings in C

Question

I want this code to print each word backwards, but is not printing the last word, I guess I'm missing something very basic here.

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

int main()
{
    int l;
    printf("lenght: ");
    scanf("%i",&l);
    char str[l][100];
    int lenght[l];

    for(int i=0; i<l; i++)
    {
        printf("%i : ",i);
        scanf("%s",str[i]);
        lenght[i] = strlen(str[i]);
    }

    for(int i=l-1; i>0; i--)
    {
        for(int j=lenght[i-1]; j>=0; j--)
        {
            printf("%c",str[i][j]);
        }
        printf("\n");
    }



   return 0; 
}

You need to usei >= 0 in this for loop: for(int i=l-1; i>=0; i--) — André Caceres
– André Caceres, Commented Feb 23, 2020 at 13:03
Or, for(int i=l; i-- >0;) for the outer loop, and for(int j=lenght[i]; j-- >0;) for the inner. — WhozCraig
– WhozCraig, Commented Feb 23, 2020 at 13:09

Aykhan Hagverdili · Accepted Answer · 2020-02-23 13:14:40Z

1

i > 0 and lenght[i - 1] are causing the problem. Also consider using putchar to print a single char and size_t to represent size of a string:

for (size_t i = l; i--;) {
  for (size_t j = lenght[i]; j--;) {
    putchar(str[i][j]);
  }
  putchar('\n');
}

edited Feb 23, 2020 at 13:14

answered Feb 23, 2020 at 13:03

Aykhan Hagverdili

30.5k6 gold badges53 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user29893 Over a year ago

why did you changed your answer, the other one worked perfectly fine, there's any difference ?

Aykhan Hagverdili Over a year ago

@user29893 Either way is fine. This way seems more clear to me (no need for the magic number -1)

Eraklon · Accepted Answer · 2020-02-23 13:05:37Z

1

This is the problem for(int i=l-1; i>0; i--).Currently the 0 index string is never processed. Set condition to i >= 0 to include 0 also.

The inner loop initialization also need to be changed to j = lenght[i] - 1.

edited Feb 23, 2020 at 13:05

answered Feb 23, 2020 at 12:52

Eraklon

4,3182 gold badges15 silver badges30 bronze badges

Collectives™ on Stack Overflow

Print array of reversed strings in C

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related