BASH conditional if statement ANDing two commands that output true or false

Question

In BASH, I have an if statement like so:

if dokku ps:report $APP_NAME --deployed && ! dokku certs:report $APP_NAME --ssl-enabled; then echo "works"; fi

Each command outputs true or false. I want the then clause to get executed when the first command outputs true and the second outputs false (which is why I have the !). But when I run this, it outputs:

true
false

If I run the second command individually:

dokku certs:report $APP_NAME --ssl-enabled

It outputs false. So the negation in my original if statement isn't working. What am I doing wrong here?

that other guy · Accepted Answer · 2020-03-07 17:28:46Z

2

Here's an easier way to reproduce your problem:

if echo false
then
  echo "Why does this print?"
fi

This is because the command output is irrelevant. if, && and || all look at the command's exit code. They don't try to interpret English text.

You can instead use string comparison:

if [ "$(dokku ps:report $APP_NAME --deployed)" = "true" ] && [ "$(dokku certs:report $APP_NAME --ssl-enabled)" = "false" ]
then ...

answered Mar 7, 2020 at 17:28

that other guy

125k12 gold badges187 silver badges214 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

BASH conditional if statement ANDing two commands that output true or false

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related