create an array via loop

Question

I need to create an array of strings, easy enough... the only problem is that the strings are integers from 1-1000 and I really dont want to type each of them.

Can you create a loop that could create this?

right now it looks like this

        private readonly string[] _myArray = { "1", "2", "3", "4", "5" };

and its called by

        for (var i = 0; i < _myArray.Length; i++)
        {
            arFoo[i].SetBar(_myArray[i]);
        }

any suggestions on how to add the other 995 without manually typing them?

Are you generating random integers? Could you simply use the C# Random library to generate 1000 ints, convert them to strings, and then run the for loop? — Kyle
– Kyle, Commented May 20, 2011 at 21:02
I do not know if the readonly feature is important to you, but if it is, I see a lot of noise on the answers, as many of them disregard this detail — sergiol
– sergiol, Commented May 20, 2011 at 23:21

Andrew Hare · Accepted Answer · 2011-05-20 21:03:21Z

7

This is simple and clean:

readonly string[] _myArray 
    = Enumerable.Range(1, 1000)
        .Select(i => i.ToString())
        .ToArray();

answered May 20, 2011 at 21:03

Andrew Hare

353k75 gold badges649 silver badges642 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Piotr Perak Over a year ago

Nice and clean solution. Do You know how it compares in performance to 'normal' way of doing it - in for loop?

vcsjones · Accepted Answer · 2011-05-20 21:03:24Z

5

If you want to use LINQ:

    private readonly string[] _myArray;

    public Foo()
    {
        _myArray = Enumerable.Range(1, 1000).Select(s => s.ToString()).ToArray();
    }

Or more traditionally:

public class Foo
{
    private readonly string[] _myArray;

    public Foo()
    {
        _myArray = new string[1000];
        for(int i=1; i<=1000; i++)
        {
            _myArray[i - 1] = i.ToString();
        }
    }
}

answered May 20, 2011 at 21:03

vcsjones

142k34 gold badges300 silver badges294 bronze badges

Comments

Dustin Hodges · Accepted Answer · 2011-05-20 21:02:03Z

2

How about

int NumberOfElements = 1000;
String[] Array = new String[NumberOfElements];

for(int i=0; i<Array.Length; i++)
{
   Array[i] = (i + 1).ToString();
}

answered May 20, 2011 at 21:02

Dustin Hodges

4,1933 gold badges28 silver badges42 bronze badges

2 Comments

vcsjones Over a year ago

Yours will do 0-999, not 1-1000.

BrMcMullin Over a year ago

Unless he needs the array to contain 1 in the first element. If so, this would probably work a little better: for(int i = 1; i<=NumberOfElements; i++ )

codekaizen · Accepted Answer · 2011-05-20 21:02:07Z

2

Do you need an array? You could just do this:

for (var i = 0; i < 1000; i++)       
{            
   arFoo[i].SetBar(i.ToString()); 
}

If you do need an array, understand that arrays in C# (and in .Net) are fixed-size. You would need another data structure, like a List<String> in order to add elements, then you can transform to an array (if truly needed) via ToArray().

answered May 20, 2011 at 21:02

codekaizen

27.4k7 gold badges87 silver badges141 bronze badges

Comments

Anthony Pegram · Accepted Answer · 2011-05-20 21:03:22Z

2

var array = Enumerable.Range(1, 1000).Select(item => item.ToString()).ToArray();

answered May 20, 2011 at 21:03

Anthony Pegram

128k28 gold badges229 silver badges252 bronze badges

Comments

danyolgiax · Accepted Answer · 2011-05-20 21:04:39Z

2

int[] arr = Enumerable.Range(1, 1000).ToArray();

answered May 20, 2011 at 21:04

danyolgiax

13.2k10 gold badges71 silver badges118 bronze badges

2 Comments

danyolgiax Over a year ago

I was writing while @Anthony-Pegram posted! :(

Piotr Perak Over a year ago

This is not array of strings.

carlosfigueira · Accepted Answer · 2011-05-20 21:14:21Z

2

_myArray = new string[1000];
for (int i = 1; i <= 1000; i++) _myArray[i - 1] = i.ToString();

edited May 20, 2011 at 21:14

answered May 20, 2011 at 21:01

carlosfigueira

87.7k14 gold badges137 silver badges176 bronze badges

Comments

PrettyPrincessKitty FS · Accepted Answer · 2011-05-21 10:26:54Z

2

string[] arr = new string[1000];
for (int i = 1; i <= 1000; i++)
{
    arr[i-1] = i.ToString();
}

edited May 21, 2011 at 10:26

answered May 20, 2011 at 21:01

PrettyPrincessKitty FS

6,4185 gold badges39 silver badges51 bronze badges

4 Comments

vcsjones Over a year ago

arr[i] should be arr[i-1]

Piotr Perak Over a year ago

Just change new int[1000] to new string[1000], and array indexes start from 0.

vcsjones Over a year ago

string[] arr = new int[1000]; doesn't even compile.

PrettyPrincessKitty FS Over a year ago

@Peri @vcsjones Originally I had read the question wrong and assumed it was integers he had wanted..I guess I must've missed out some parts when changing it. And the array indices were from a previous edit I missed.

ColinE · Accepted Answer · 2011-05-20 21:02:50Z

1

You can simply do it in a for loop as follows, calling ToString on the int 'i'

private string[] _myArray = new string[1000];

for(int i=0;i<1000;i++)
{
  _myArray[i] = i.ToString();
}

answered May 20, 2011 at 21:02

ColinE

70.3k16 gold badges171 silver badges236 bronze badges

Comments

Jonathan Wood · Accepted Answer · 2011-05-20 21:04:37Z

1

private readonly string[] _myArray = new string[1000];

for (int i = 0; i < _myArray.Length; i++)
    _myArray[i] = i.ToString();

answered May 20, 2011 at 21:04

Jonathan Wood

68.1k86 gold badges308 silver badges542 bronze badges

Comments

Piotr Perak · Accepted Answer · 2011-05-20 22:53:40Z

0

This is method that will generate array of string from 'from' to 'to' inclusive.

private string[] GetNumbers(int from, int to)
{
  int size = to - from + 1;
  string[] result = new string[size];
  int number = from;
  for (int i = 0; i < size; i++)
  {
    result[i] = number.ToString();
    number++;
  }
  return result;
}

string[] numbers = GetNumbers(1, 1000); // to get what You want

answered May 20, 2011 at 22:53

Piotr Perak

11.2k10 gold badges57 silver badges97 bronze badges

Collectives™ on Stack Overflow

create an array via loop

11 Answers 11

1 Comment

Comments

2 Comments

Comments

Comments

2 Comments

Comments

4 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

11 Answers 11

1 Comment

Comments

2 Comments

Comments

Comments

2 Comments

Comments

4 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related