Java boolean issue

Question

private static final Pattern namePattern = 
    Pattern.compile("[a-zA-Z0-9_-]{3,12}");

if (player.getName().length() < 3 || 
        player.getName().length() > 12 || 
        namePattern.matcher(player.getName()).matches()) {
    player.ban("[Autoban] Character-name PE", true);
    return;
}

The code is kinda obvious, I hope

If the players name is longer than 12 or shorter then 3, or have any symbols that shouldnt be i a name = BAM, ban!

but even thought my player name is like Chaos or test, it gets autobanned by this code. idk if the namepattern Pattern blocks characters aswell, I just it to block symbols like "!#&%¤/&%(/)(/(=)$@£$@£{€@£ yeh... What am I doing wrong :(?

MByD · Accepted Answer · 2011-05-21 15:21:32Z

3

I think you meant (!namePattern.matcher(player.getName()).matches()).

Also, you could've use only the regex match: [a-zA-Z0-9_-]{3,12} since it checks for length.

Edit:

You can use such a function

public void banIfNeeded(Player player)
{
    Pattern namePattern = Pattern.compile("[a-zA-Z0-9_-]{3,12}");
    if(!namePattern.matcher(player.getName()).matches()) {
        System.out.print("Banned"); 
        // Ban somehow
    }
}

As @bkail commented (thanks!), there's no need for the ^ and \z so I removed them :)

edited May 21, 2011 at 15:21

answered May 21, 2011 at 14:22

MByD

138k30 gold badges269 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

PirateOwh Over a year ago

Thanks it works now but even if my char is named something with !"__#!"_#! or a symbol like that, it doesnt get banned. only lenght check seems to work.

Brett Kail Over a year ago

Anchors ("^" and "\z") are unnecessary when using .matches().

PirateOwh Over a year ago

How can I check if the player use a symbool in the name then? i want to block all symbols

PirateOwh Over a year ago

How can I check if the player use a symbool in the name then? i want to block all symbols

MByD Over a year ago

I just gave you an example. just use player.getName() instead of s.

|

Collectives™ on Stack Overflow

Java boolean issue

1 Answer 1

11 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

11 Comments

Your Answer

Sign up or log in

Post as a guest

Related