why my desired string is not replacing with another in javascript? [duplicate]

Question

I have this string

content = 'Hi John Doe,

Your appointment has been scheduled for 30-Mar-20 at 05:00 pm.  
Please confirm your appointment. [link]'

confirmationTagsArray = [
  {tag : '[customer_name]' : value : 'John Doe'},
  {tag : '[startDate]' : value : '30-Mar-20'},
  {tag : '[start_time]' : value : '05:00 pm'},
];

Here is my function to replace strings

  parseBackConfirmationText() {
   let str = this.content;
   this.confirmationTagsArray.forEach(tag => {
     if (str.includes(tag.value)) {
      str.replace(tag.value, tag.tag);
     }
   });
   return str;
  }

In this function i am replacing some strings with another strings in a loop. But it's not replacing the strings. It returns me the same string that i provided like this

Hi John Doe,

Your appointment has been scheduled for 30-Mar-20 at 05:00 pm.  
Please confirm your appointment. [link]

But it should return like this

Hi [customer_name],

Your appointment has been scheduled for [start_date] at [start_time].  
Please confirm your appointment. [link]

What am i doing wrong?

Please create a small demo for this and post in your queestion. — palaѕн
– palaѕн, Commented Mar 30, 2020 at 12:11
str.replace(tag.value, tag.tag); should be str = str.replace(tag.value, tag.tag); — ankr
– ankr, Commented Mar 30, 2020 at 12:12

Mamun · Accepted Answer · 2020-03-30 12:17:00Z

1

You have few issues in your code:

Your object is syntactically invalid.
You have to declare the function with function keyword.
replace() does not modify the the original string, you have to reassign the modified string to the variable.

Try the following way:

content = `Hi John Doe,

Your appointment has been scheduled for 30-Mar-20 at 05:00 pm.  
Please confirm your appointment. [link]`

confirmationTagsArray = [
  {tag : '[customer_name]', value : 'John Doe'},
  {tag : '[startDate]', value : '30-Mar-20'},
  {tag : '[start_time]', value : '05:00 pm'},
];

function parseBackConfirmationText() {
 let str = content;
 confirmationTagsArray.forEach(tag => {
   if (str.includes(tag.value)) {
    str = str.replace(tag.value, tag.tag);
   }
 });
 return str;
}
console.log(parseBackConfirmationText());

answered Mar 30, 2020 at 12:17

Mamun

69k9 gold badges51 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Fahad Hassan Over a year ago

I am using angular so no need of declare function with function keyword. Anyway your answer helped me out. Thanx.

Collectives™ on Stack Overflow

why my desired string is not replacing with another in javascript? [duplicate]

1 Answer 1

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Linked

Related