External javascript File Problem

Question

Good day!

Why is it that when I make the following javascript code external, some codes doesn't work

<form name="Keypad" action="">
</form>


                        var FKeyPad = document.Keypad; // DOESN'T WORK ANYMORE
                        var Accumulate = 0;
                        var FlagNewNum = false;
                        var PendingOp = "";
                        function NumPressed (Num) {
                            if (FlagNewNum) {
                                FKeyPad.ReadOut.value  = Num;
                                FlagNewNum = false;
                            }
                            else {
                                if (FKeyPad.ReadOut.value == "0")
                                    FKeyPad.ReadOut.value = Num;
                                else
                                    FKeyPad.ReadOut.value += Num;
                            }
                        }

How can I make it work?

Thank you,

opps. my bad :) and if you are mentioning to this article javascript.internet.com/math-related/advanced.html , would say lousy code. dont copy :) — codeandcloud
– codeandcloud, Commented May 24, 2011 at 5:43
if using jquery $(function (){...code...}) else onload event — Ibu
– Ibu, Commented May 24, 2011 at 5:46

Guffa · Accepted Answer · 2011-05-24 05:37:42Z

2

It has nothing to do with the code being external, it's all about when the code is executed.

You have to execute the code after the element has been created. You can put the script tag below the element in the code, or you can put the code in the handler for the window.onload event to make it run after the page has loaded:

window.onload = function() {
  // your code here
};

answered May 24, 2011 at 5:37

Guffa

703k111 gold badges760 silver badges1k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

newbie Over a year ago

Where would i put the window.onload?

newbie Over a year ago

in my javascript external file or in my hmtl? Thank you

beatgammit Over a year ago

I would suggest using a library like Mootools or something. It will make life easier.

Ionuț Staicu · Accepted Answer · 2011-05-24 05:42:46Z

1

Include your external JS file just before </body> tag and should work.

answered May 24, 2011 at 5:42

Ionuț Staicu

22.3k11 gold badges54 silver badges58 bronze badges

Comments

Emyr · Accepted Answer · 2011-05-24 05:32:54Z

1

I can't find any sources which mention document.Keypad. I don't think it's supported by normal browsers.

answered May 24, 2011 at 5:32

Emyr

2,38118 silver badges39 bronze badges

Collectives™ on Stack Overflow

External javascript File Problem

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related