Can't add string to a string type variable in Python

Question

I wanted to make a very simple network scanner in python, and I wrote this:

import subprocess
ip_range = input("Enter ip range:")
start_ip = input("Enter start ip:")
end_ip = input("Enter end ip:")
result = "Result:"
for ping in range(int(start_ip), int(end_ip)):
    ip = ip_range + str(ping)
    connect = subprocess.call(["ping", "-c1",ip])
    if connect == 0:
        result += "---"
        result += "Ping to ",ip,"was OK"
        result += "---"
    else:
        result + "Couldn't ping to " + str(ip)
        result + "---"
        pass
print(result)

All of them work correct except one thing. In this part

result + "Couldn't ping to " + str(ip)
result + "---"

The result doesn't add up to this code, I mean it just write result.

Look closely at the difference between the two branches of your if statement. You use two different operators. — Brian61354270
– Brian61354270, Commented Apr 9, 2020 at 14:28

Josh Clark · Accepted Answer · 2020-04-09 14:28:23Z

1

result + "Couldn't ping to " + str(ip) is an expression, not a statement. You don't assign that value to result. Try changing the + to +=. That will store the value result + "Couldn't ping to " + str(ip) in result.

answered Apr 9, 2020 at 14:28

Josh Clark

1,0222 gold badges10 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Hosein Azimi Over a year ago

I tries += instead of + but the answere will be replace with the last value and doesn't add together.

Josh Clark Over a year ago

@HoseinAzimi I don't understand your comment. Can you be more explicit about what code you are using and the output you are expecting?

Hosein Azimi Over a year ago

I wanna user input a ip range and then script go and ping the ips and know what ips are up and what ips are down,then add result to a string variable for example: ip_range:192.168.1.100 - 192.168.1.110 ping all of them was ok result:--Ping to 192.168.1.100 was OK------Ping to 192.168.1.101 was OK------ etc.

Collectives™ on Stack Overflow

Can't add string to a string type variable in Python

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related