Problem with PHP Syntax

Question

I am trying to get a link together using 2 variables but the output is the link and title but no html / clickable link appearing.

I'm getting something link this:

http://www.mydomain.com/post1/post_title_here

Here is the code:

echo '<a href="'.the_permalink().'">'.the_title().'</a>';

Can anyone help please?

Thanks

UPDATE:

Here's the whole block of code:

<div id="MyBlock1">
        <?php
            $query = new WP_Query('posts_per_page=5');

             while( $query ->have_posts() ) : $query ->the_post();
                 echo '<li>';
                 echo '<a href="'.the_permalink().'">'.the_title().'</a>';
                 echo '</li>';
             endwhile;

            wp_reset_postdata();

        ?>
    </div>

Code looks fine to me. What is getting rendered? What is the return value of the_permalink()? — Rafe Kettler
– Rafe Kettler, Commented May 24, 2011 at 15:47
paste the code from the permalink function so we know what it returns — amosrivera
– amosrivera, Commented May 24, 2011 at 15:48
As a general rule, if a function in Wordpress generates output of some sort, then the_function() sends the output directly to the client, while get_the_function() returns its output instead. — Marc B
– Marc B, Commented May 24, 2011 at 16:03

Johannes P. · Accepted Answer · 2011-05-24 16:07:13Z

That's because the wordpress functions the_permalink() and the_title() display the respective outcomes already they need not be echoed. If you want functions that return the values, you have to use get_permalink() and get_the_title() instead.

So either do:

<div id="MyBlock1">
    <?php
        $query = new WP_Query('posts_per_page=5');
        while( $query ->have_posts() ) : $query ->the_post();
            echo '<li>';
            echo '<a href="'.get_permalink().'">'.get_the_title().'</a>';
            echo '</li>';
        endwhile;
        wp_reset_postdata();
   ?>
</div>

or

<div id="MyBlock1">
    <?php
        $query = new WP_Query('posts_per_page=5');
        while( $query ->have_posts() ) : $query ->the_post();
            echo '<li><a href="';
            the_permalink();
            echo '">';
            the_title();
            echo '</a></li>';
        endwhile;
        wp_reset_postdata();
   ?>
</div>

Both will work.

Saurav · Accepted Answer · 2011-05-24 15:49:10Z

2

Here's a checklist for debugging:

1.) Is the_title() returning an empty string? (You can check by looking at the html source)

2.) Are you echoing this inside of the body tag?

3.) Is this being echoed in a hidden html element?

answered May 24, 2011 at 15:49

Saurav

3,1443 gold badges22 silver badges12 bronze badges

Comments

ceejayoz · Accepted Answer · 2011-05-24 15:52:17Z

2

echo '<a href="'.the_permalink().'">'.the_title().'</a>';

In this sort of situation, you'll want to use get_permalink instead of the_permalink and get_the_title instead of the_title.

echo '<a href="'.get_permalink().'">'.get_the_title().'</a>';

WordPress the_* functions do a direct echo call, whereas the get_* functions return a value that you can use for further processing, like the concatenation you're doing.

(also note the inconsistent naming conventions - this can be a pain)

answered May 24, 2011 at 15:52

ceejayoz

181k42 gold badges311 silver badges382 bronze badges

Comments

Jürgen Thelen · Accepted Answer · 2011-05-24 15:52:37Z

2

You could use the corresponding get_* versions:

echo '<a href="' . get_permalink() . '">' . get_the_title() . '</a>';

See the codex reference for more

answered May 24, 2011 at 15:52

Jürgen Thelen

12.7k7 gold badges54 silver badges74 bronze badges

1 Comment

ceejayoz Over a year ago

It's actually get_the_title.

Aleski · Accepted Answer · 2011-05-24 15:48:30Z

0

You need to absolutely make sure that .the_title(). is definately bieng set a value. If it isn't, then there will be no displayed HTML as there is no text for the anchor tag. Just a thought (i've done it many times, try print_f(); ing the the_title(). Hope it helped.

answered May 24, 2011 at 15:48

Aleski

1,4425 gold badges16 silver badges31 bronze badges

1 Comment

Satch3000 Over a year ago

Both variable are returning values.

Collectives™ on Stack Overflow

Problem with PHP Syntax

5 Answers 5

Comments

Comments

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related