change value of an array element, Laravel

Question

I want to create an array of objects, and if some of them are duplicate,I want to increase some fields like (Votes/Score/Percentage), all good..in dump(I get the edited value,but on last dd ,the array is not modified. There I have all elements.

At the end I have 16 array elements (13 +3 with the same lkp_answer_id), insted of 13.

$history = AnswerHistory::where('question_id', '=', $id)->get();
$answers = $history->toArray();
$most_voted = [];
        foreach ($answers as $key => $answer) {
            if (!empty($most_voted)) {
                foreach ($most_voted as $best) {
                    //If value already exists, increase Votes/Score/Percentage
                    if ($best['answer_id'] == $answer['lkp_answer_id']) {
                        $best['Votes']++;
                        $best['Score'] = $best['Score'] + $answer['score'];
                        $best['Percentage'] = substr((($best['Votes'] * 100) / $query->votes), 0, 5);
                        $best['Weight'] = substr((($best['Score'] * 100) / $query->total_scoring), 0, 5);
                        dump($best);  //here the array element is changed (correct)
                    //Else add new array element
                    } else {
                        $most_voted[$key] = [
                            'answer_id' => $answer['lkp_answer_id'],
                            'Votes' => 1,
                            'Score' => $answer['score'],
                            'Percentage' => substr(((1 * 100) / $query->votes), 0, 5),
                            'Weight' => substr((($answer['score'] * 100) / $query->total_scoring), 0, 5),
                        ];
                    }
                }
            } else {
                //If $most_voted is null, insert first value
                $most_voted[$key] = [
                    'answer_id' => $answer['lkp_answer_id'],
                    'Votes' => 1,
                    'Score' => $answer['score'],
                    'Percentage' => substr(((1 * 100) / $query->votes), 0, 5),
                    'Weight' => substr((($answer['score'] * 100) / $query->total_scoring), 0, 5),

                ];
            }
        }

        dd($most_voted); //here I have a full list with, even duplicate ones

I edited the post, but I don't think that it matters. The problem is that the array element values are not changed at the end.. — Beusebiu
– Beusebiu, Commented Apr 15, 2020 at 11:09

Senthurkumaran · Accepted Answer · 2020-04-15 11:21:07Z

1

Change your code like below and try

$history = AnswerHistory::where('question_id', '=', $id)->get();
$answers = $history->toArray();
$most_voted = [];
        foreach ($answers as $key => $answer) {
            if (!empty($most_voted)) {
                foreach ($most_voted as $k => $v) {
                    //If value already exists, increase Votes/Score/Percentage
                    if ($most_voted[$k]['answer_id'] == $answer['lkp_answer_id']) {
                        $most_voted[$k]['Votes']++;
                        $most_voted[$k]['Score'] = $most_voted[$k]['Score'] + $answer['score'];
                        $most_voted[$k]['Percentage'] = substr((($most_voted[$k]['Votes'] * 100) / $query->votes), 0, 5);
                        $most_voted[$k]['Weight'] = substr((($most_voted[$k]['Score'] * 100) / $query->total_scoring), 0, 5);
                        dump($most_voted[$k]);  //here the array element is changed (correct)
                    //Else add new array element
                    } else {
                        $most_voted[$key] = [
                            'answer_id' => $answer['lkp_answer_id'],
                            'Votes' => 1,
                            'Score' => $answer['score'],
                            'Percentage' => substr(((1 * 100) / $query->votes), 0, 5),
                            'Weight' => substr((($answer['score'] * 100) / $query->total_scoring), 0, 5),
                        ];
                    }
                }
            } else {
                //If $most_voted is null, insert first value
                $most_voted[$key] = [
                    'answer_id' => $answer['lkp_answer_id'],
                    'Votes' => 1,
                    'Score' => $answer['score'],
                    'Percentage' => substr(((1 * 100) / $query->votes), 0, 5),
                    'Weight' => substr((($answer['score'] * 100) / $query->total_scoring), 0, 5),

                ];
            }
dd($most_voted); //here I have a full list with, even duplicate ones

edited Apr 15, 2020 at 11:21

answered Apr 15, 2020 at 11:17

Senthurkumaran

1,8882 gold badges22 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

13 Comments

Senthurkumaran Over a year ago

try again and give the dump and dd output.

Beusebiu Over a year ago

I tried with something simple like " $best['Votes'] =12345 , but in the final dd the array is unchanged..

Senthurkumaran Over a year ago

you try like my code and give the output. Like your above comment didn't work.

Beusebiu Over a year ago

Here is the output: codeshare.io/5ZO7oe , the values are changed now, but I stii get duplicate answer_id ,in array..

Beusebiu Over a year ago

Yes, but with duplicates, but is OK, for what I need next it doesn't bother me. Thanks a lot!

|

Collectives™ on Stack Overflow

change value of an array element, Laravel

1 Answer 1

13 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

13 Comments

Your Answer

Sign up or log in

Post as a guest

Related