Javascript - Adding multiple values to keys

Question

I am trying to find the places of each letter in a sentence by using "dictionaries". The problem is I want to find all the places that each letter is and not only the last one. I am very new to JavaScript and couldn't figure out the way to do it.

function letters(stringArgument) {
stringArgument = stringArgument.replace(/ /g,'');
var dict = {};
for (var i=0; i < stringArgument.length; i++ )

    if (!stringArgument[i] in dict){
       dict[stringArgument[i]] = [];
    }else{
       dict[stringArgument[i]] = [i+1]
    }
return dict
}
var a = letters('Lost time is never found again.');
console.log(a);

naturally gives this output:

{   L: [ 1 ],   o: [ 17 ],   s: [ 10 ],   t: [ 5 ]...

but it should give this:

{   L: [ 1 ],   o: [ 2, 17 ],   s: [ 3, 10 ],   t: [ 4, 5 ]...

Also each letter is saved to the dictionary at the same order they appear in the sentence, how can I order the letters alphabetically?

Property names in objects cannot be ordered other than in the way the runtime naturally behaves. You can extract the property names yourself however and sort them for presentation. — Pointy
– Pointy, Commented Apr 19, 2020 at 13:52

Aadil Mehraj · Accepted Answer · 2020-04-19 14:23:14Z

2

What you need is a function that gets the positions of a character in a given string.

Try this:

function findAllPositions(char, content) {
    var result = [];
    let index = content.indexOf(char);

    while(index !== -1) {
        result.push(index);
        index = content.indexOf(char, index + 1);
    }

    return result;

}

findAllPositions('o', 'Lost time is never found again.'); // Result =  [1, 20]

Using this we can update the letter function as follows:

function letters(stringArgument) {
  stringArgument = stringArgument.replace(/ /g, '');
  var dict = {};
  for (const char of stringArgument) {
    dict[char] = findAllPositions(char, stringArgument)
  }
  return dict;
}

letters('is again.')
/*
{
    "i": [0, 5],
    "s": [1],
    "a": [2, 4],
    "g": [3],
    "n": [6],
    ".": [7]
}
*/

answered Apr 19, 2020 at 14:23

Aadil Mehraj

2,6141 gold badge9 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nina Scholz · Accepted Answer · 2020-04-19 14:01:01Z

You need to have

parantheses for the check
```
if (!(stringArgument[i] in dict)) {
```
create an array if the above is true
push the postion to the array

For getting a sorted output, you could take the entries of the object, apply a sorting by taking the key and show the result in order.

Object have an insertation oder for not positive 32 bit numbers (like indixes) or symbols. The index like numbers are sorted by value and appears first in the object.

function letters(stringArgument) {
  stringArgument = stringArgument.replace(/ /g, '');
  var dict = {};
  for (var i = 0; i < stringArgument.length; i++) {
    if (!(stringArgument[i] in dict)) {
      dict[stringArgument[i]] = [];
    }
    dict[stringArgument[i]].push(i + 1);
  }
  return dict;
}

var a = letters('Lost time is never found again.');

Object
    .entries(a)
    .sort(([a], [b]) => a.localeCompare(b))
    .forEach(([key, positions]) => console.log(key, ...positions));

console.log(a);

Kingson · Accepted Answer · 2020-04-19 14:05:38Z

1

First, for any item, if it is not in an empty array:

var notInDict = !(stringArgument[i] in dict);

If not in dict, then initialize an empty array and push the item in it using

dict[stringArgument[i]].push(i + 1);

Try this.

function letters(stringArgument) {
  stringArgument = stringArgument.replace(/ /g, "");
  var dict = {};
  for (var i = 0; i < stringArgument.length; i++) {
    var notInDict = !(stringArgument[i] in dict);
    if (notInDict) {
      dict[stringArgument[i]] = [];
    }
    dict[stringArgument[i]].push(i + 1);

  }
  return dict;
}
var a = letters("Lost time is never found again.");
console.log(a);

answered Apr 19, 2020 at 14:05

Kingson

1193 bronze badges

Comments

shashi srinath · Accepted Answer · 2020-04-19 14:31:25Z

you are assigning a new array at each iteration

dict[stringArgument[i]] = [i+1]

what you need to do is push the new position to existing array.

dict[stringArgument[i]].push(i+1)

also, remove the else block

function letters(stringArgument) {
    stringArgument = stringArgument.toLowerCase().replace(/ /g,'');
    var dict = {};
    for (var i=0; i < stringArgument.length; i++ ){
        if (!dict.hasOwnProperty(stringArgument[i])){
           dict[stringArgument[i]] = [];
        }
        dict[stringArgument[i]].push(i+1);
    }

    //sorting
    var letters = Object.keys(dict); //returns a array

    letters.sort();

    var sortedDic = {};
    for(var i in letters) {
       sortedDic[letters[i]] = dict[letters[i]];
    }

    return sortedDic;
    }
    var a = letters('Lost time is never found again.');
    console.log(a);

Mister Jojo · Accepted Answer · 2020-04-19 14:44:29Z

1

for the first part you can also do that:

let  sentence = 'Lost time is never found again.'

let tabLetters = [...sentence.replace(/ /g,'')].reduce((a,c,i)=>
  {
  if (!a[c]) a[c] = [i+1]
  else       a[c].push(i+1)
  return a
  },{})

document.write(JSON.stringify(tabLetters))

answered Apr 19, 2020 at 14:44

Mister Jojo

22.9k6 gold badges28 silver badges45 bronze badges

Collectives™ on Stack Overflow

Javascript - Adding multiple values to keys

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related