PHP if-statement always returns false

Question

I am using a PHP function with a simple if else statement. If variable = 100 do something, else do something else.

The data is coming from an ACF Range Field. For some reason, the function always returns the else-statement even though the ACF field is = 100. I figured the problem is the if-statement where I've tried to use: =, ==, !==, === or >=. If I change it to single = then it always returns h2 Something but all the rest returns h2 something else no matter what value I put in the ACF Range field.

function hovsa_shortcode() {
    $full_tegnet = get_field("tegnede_andele_");
    if ( $full_tegnet == '100' ) {

        return '<h2>Something</h2>';

    } else {

        return '<h2>Something else</h2>';

    }
}

add_shortcode( 'hovsa', 'hovsa_shortcode' );

What happens if you do var_dump($full_tegnet)? And what does strlen($full_tegnet) return? — MC Emperor
– MC Emperor, Commented Apr 26, 2020 at 9:27
The simple equal sign is an assignment. This is only in exceptional cases in an IF and makes the code illegible.The double equal sign is the comparison operator and should match.As @MC Emperor said, what does var_dump print? — chriss
– chriss, Commented Apr 26, 2020 at 9:52
hmm.. For some reason, var_dump returns null. I have used get_field before with great success. Something like this: $tegnet = get_field("tegnede_andele_"); - $maxvalue = ($tegnet == 100) ? 0 : 10000; — TurboTobias
– TurboTobias, Commented Apr 26, 2020 at 9:55
ACF get_field Try to use get_field() with the post id and disable any formatting logic: <?php $full_tegnet = get_field('tegnede_andele_', get_the_ID(), false); If still null, then your field is really null! — aliirfaan
– aliirfaan, Commented Apr 26, 2020 at 10:26
it still returns null... However, I found out that the issue is that I am trying to get data outside the loop. If I echo something like this then it echos 100: global $wp_query; $postid = $wp_query->post->ID; echo get_post_meta($postid, 'tegnede_andele_', true); wp_reset_query(); — TurboTobias
– TurboTobias, Commented Apr 26, 2020 at 11:00

giovybus · Accepted Answer · 2020-04-26 09:53:10Z

1

assuming the $full_tegnet should be an integer you can use following

if(intval($full_tegnet) === 100){
     return '<h2>Something</h2>';
}

edited Apr 26, 2020 at 9:53

giovybus

3591 gold badge3 silver badges11 bronze badges

answered Apr 26, 2020 at 9:30

Daisen Sekai

1737 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

aliirfaan · Accepted Answer · 2020-04-26 10:35:13Z

According to documentation ACF Range field is a numeric value. As stated by @Daisen Sekai, you can cast $full_tegnet by using intval() in your condition and use strict equality for comparison.

<?php $full_tegnet = intval($full_tegnet); if ($full_tegnet === 100) { // your logic }
But PHP does type juggling and if $full_tegnet = 100, your statement if ( $full_tegnet == '100' ) should return true. You can test this piece of code in a script and see the result:

<?php $full_tegnet = 100; if ( $full_tegnet == '100' ) { echo '<h2>Something</h2>'; } else { echo '<h2>Something else</h2>'; }
There may be other issues in your code, more possibly value of $full_tegnet that is causing this. As commented by @MC Emperor, do a var_dump($full_tegnet) to get value/type of $full_tegnet
Use built in ACF shortcode to see what is being returned

[acf field="{$tegnede_andele_}"]

Collectives™ on Stack Overflow

PHP if-statement always returns false

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related