How to change instance variable when another related instance variable is changed in a class?

Question

I recently try to code a text based game. I want to change player proficiency when player level up. How should I change my code for this?

class Player:
    def __init__(self,name,_class,_race):
        self.name = name
        self.level = 1
        self.proficiency = (int(self.level/3)+1)*2
        self.inventory = 0
        self.skills = returnSkills()
        self.stats = returnStats()
        self._class = _class
        self._race = _race
        self.exp = 0

    def levelUp(self):
        self.level+=1


newPlayer = Player("Player","Barbarian","Human")

print(newPlayer.level)

for i in range(10):
    print(newPlayer.level)
    print(newPlayer.proficiency)
    newPlayer.levelUp()

You could make proficiency a property, so it is calculated from the current level each time it is referenced. — khelwood
– khelwood, Commented May 9, 2020 at 0:43

ericstevens26101 · Accepted Answer · 2020-05-09 01:02:30Z

1

You can recalculate the proficiency attribute directly in the levelUp() function. Once you have updated the level attribute, that new value of level will be used to calculate the new proficiency.

    def levelUp(self):
        self.level+=1
        self.proficiency = (int(self.level/3)+1)*2

edited May 9, 2020 at 1:02

answered May 9, 2020 at 0:45

ericstevens26101

1219 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

khelwood · Accepted Answer · 2020-05-09 00:44:36Z

0

You could make proficiency a property, so it is calculated from the current level each time it is referenced.

class Player:
    def __init__(self,name,_class,_race):
        self.name = name
        self.level = 1
        self.inventory = 0
        self.skills = returnSkills()
        self.stats = returnStats()
        self._class = _class
        self._race = _race
        self.exp = 0

    @property
    def proficiency(self):
        return (int(self.level/3)+1)*2
    ...

or you could leave it as a plain attribute, and recalculate it inside your levelUp method.

answered May 9, 2020 at 0:44

khelwood

59.7k14 gold badges91 silver badges116 bronze badges

2 Comments

ericstevens26101 Over a year ago

function decorators might be a little advanced for someone who is asking this question. in fact, i have been writing python for a few years now and you taught me something new, so thanks! :)

Reblochon Masque Over a year ago

If you learned something new, you should probably up-vote this answer @ericstevens26101

Collectives™ on Stack Overflow

How to change instance variable when another related instance variable is changed in a class?

2 Answers 2

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related