Android Repository Implementation with Interface

Question

Usually, I use an Interface for my repositories:

interface UserRepository {
    fun add()
    fun get(userId): User
    .....
}

I have three types of Repositories (InMemory, Database, and Network):

They all implement UserRepository: UserInMemoryRepository - UserDatabaseRepository - UserNetworkRepository

But my network doesn't have any add user API

What is the best practice here?

Remove my UserRepository interface
Leave an empty add user method
...... (Any better approach)

You should have only one RepositoryImpl, inside it has logic when getting data from memory or database or network — Công Hải
– Công Hải, Commented May 11, 2020 at 8:42
Please take a look here developer.android.com/jetpack/docs/guide. Inside UserRepository it manage both memory cached and remote network. — Công Hải
– Công Hải, Commented May 11, 2020 at 9:23

SkypeDogg · Accepted Answer · 2020-05-11 08:38:28Z

2

Leaving add() empty doesn't goes in pair with SOLID principles. If more than one class should override some method, then you shouldn't remove interface either. What I would do is create interface:

interface Repository {
    fun get(userId): User
}
...
interface UserRepository : Repository {
     fun add()
}

Then your "Network" can implement Repository, and the rest of classes implement UserRepository. Of course naming of interfaces is up to you, but according to 'I' in SOLID it is better to have more dedicated interfaces rather than one multifunctional

edited May 11, 2020 at 8:38

answered May 11, 2020 at 8:29

SkypeDogg

1,0402 gold badges15 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Android Repository Implementation with Interface

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related