How to filter an array using two parameters?

Question

I have a program that adds or removes cars to an array called pile so that the cars can later be selected based on filters and criteria. The code works as it is but I am trying to increase it's efficiency for later changes. Below is code to show what my question is:

if ( var1 == true ) {
  pile.push(car1);
} else if ( var1 == false ) {
  pile = pile.filter( removeCar );
}

function removeCar(elem) {
  return String(elem[0][0]) !== 'Jeep';
}

What I want to do is for removeCar() to have two parameters so it is removeCar(elem, make) such that if make = 'Jeep' the code would function the same way. Unfortunately, as you can see removeCar is called by filter with no parameters and elem is automatically assigned to the current element.

How can I add parameters to the .filter( removeCar)?

interesting, you assign true to the variables and do not make a check with it. — Nina Scholz
– Nina Scholz, Commented May 13, 2020 at 15:47
I don't think this code works. If(var1 = true) will always be true because thats assignment and you will never get to the else. Also in the else you don't need to test if its false again because if it's not true it will be false assuming that its a boolean ofcourse. Now you can pass in values in to a function by so pile = pile.filter( elem => removeCar(elem) ); — Nsoseka
– Nsoseka, Commented May 13, 2020 at 15:52
yea I just didn't copy that part correctly because it is more complicated and hides the meaning of the question which is about the filter part. the question is fixed. — brothman01
– brothman01, Commented May 13, 2020 at 15:53
Okay great, that fixes it. In JS when checking for equality though it's always good to use three === but this would work — Nsoseka
– Nsoseka, Commented May 13, 2020 at 15:58
@Nsoseka technically you gave me the correct answer first but as a comment, but Dima posted the correct answer as an answer, so if you add your comment as an answer I'll mark it as the solution but if not I'll just mark Dimas — brothman01
– brothman01, Commented May 13, 2020 at 15:59

brothman01 · Accepted Answer · 2020-05-13 16:10:40Z

1

You can include parameters in the filter if you structure the statement differently: pile = pile.filter( elem => removeCar(elem, make) );

edited May 13, 2020 at 16:10

brothman01

2551 gold badge4 silver badges15 bronze badges

answered May 13, 2020 at 16:04

Nsoseka

3192 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dima Vak · Accepted Answer · 2020-05-13 15:48:59Z

1

pile = pile.filter( x => removeCar(x) );

Try this. If removeCar(x) return true, x(current element of pile) will be added to new pile array

And in your if/else must be '==' or '===' not '='

answered May 13, 2020 at 15:48

Dima Vak

6197 silver badges21 bronze badges

Comments

Rahul · Accepted Answer · 2020-05-13 16:14:05Z

0

How about this:

if (var1) pile.push(car1);
pile = filterPile(pile, make);

function filterPile(pile, make){
 if(!pile) pile;
 return pile.filter(val=> val[0][0].toString() !== make)
}

answered May 13, 2020 at 16:14

Rahul

1181 silver badge10 bronze badges

Comments

Luc125 · Accepted Answer · 2020-05-13 16:55:04Z

0

You can define custom filter functions by wrapping the native Array filter() method:

// A custom filter function which accepts a 'pile' and a 'make' parameter.
function removeFromPileByMake(pile, make) {
    // Assuming every element holds an object at [0]
    return pile.filter(elem => elem[0][0] !== make);
}

var make = 'Jeep';

if ( var1 ) {
    pile.push(car1);
} else {
    pile = removeFromPileByMake(pile, make);
}

edited May 13, 2020 at 16:55

answered May 13, 2020 at 16:29

Luc125

5,87736 silver badges35 bronze badges

Collectives™ on Stack Overflow

How to filter an array using two parameters?

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related