NSMutableArray addObject not adding objects, and object IS allocated

Question

I'm trying to use addObject: on an NSMutableArray with a class I've created, called Position. According to the logs, the Position instance that I am adding to the array is not nil -- I can output its properties to the log. However, the array never seems to actually take the Position.

@implementation Position

@synthesize tradeDirection, instrument, quantity, fill, profit, positive, index;

-(id)initWithArray:(NSArray*)data
{
    self = [super init];
    if (self)
    {
        self.tradeDirection = [data objectAtIndex:0];
        self.instrument     = [data objectAtIndex:1];
        self.quantity       = [data objectAtIndex:2];
        self.fill           = (NSNumber*)[data objectAtIndex:3];
        self.profit         = [data objectAtIndex:4];
        self.positive       = [@"True" isEqualToString:[data objectAtIndex:5]];
        self.index          = (NSNumber*)[data objectAtIndex:6];
    }
    return self;
}

+(Position*)createPositionWithString:(NSString*)data
{
    return [[[self alloc] initWithArray:[data componentsSeparatedByString:@"#"]] autorelease];
}

@end

loadPositions:data method

-(void)loadPositions:(NSString*)data
{
    TT_RELEASE_SAFELY(_positions);
    NSArray* dataArray = [data componentsSeparatedByString:@";"];
    for (int i = 2; i <= [dataArray count] - 2; i++)
    {
        //TODO: Discover why this does not add a position.
        Position* newPos = [Position createPositionWithString:[dataArray objectAtIndex:i]];
        [_positions addObject:newPos]; //position never actually gets added
        NSLog(@"Position direction: %@", newPos.tradeDirection); //logs what I expect, i.e. newPos is not nil
    }
}

After calling loadPositions:data, _positions is still nil. Pretty straightforward; I have a feeling this has something to do with memory management, but at this point I just need a second set of eyes. What am I missing?

Almost certainly you are not instantiating/retaining the _positions array correctly. Need to see more code surrounding this bit as everything else you've posted looks fine. — adam
– adam, Commented May 30, 2011 at 20:21

Coleman S · Accepted Answer · 2011-05-30 20:31:22Z

5

The TT_RELEASE_SAFELY macro sends a release message to its argument before assigning it to nil (IIRC). Why is it any surprise that _positions is nil?

While you may need to release _postitions for whatever reason, you must allocate and initialize a new object and assign its reference to _positions before you can add items to it.

edit: as Luke indicated in his comment, TT_RELEASE_SAFELY is from the three20 library.

#define TT_RELEASE_SAFELY(__POINTER) { [__POINTER release]; __POINTER = nil; }

edited May 30, 2011 at 20:31

answered May 30, 2011 at 20:25

Coleman S

4881 gold badge4 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Luke Redpath Over a year ago

This. Might I also add that if using non-standard library code (such as TT_RELEASE_SAFELY, is that from the Three20 library?) it helps to explain what it does. Not everybody uses these libraries.

adam Over a year ago

Ah yes, the timely programming paradigm classic of setting an object to nil resulting in the object being nil.

Luke Redpath Over a year ago

My comment was aimed at the OP actually but thanks for the clarification.

Collectives™ on Stack Overflow

NSMutableArray addObject not adding objects, and object IS allocated

loadPositions:data method

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

loadPositions:data method

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related