Python TypeError - : 'str' object is not callable

Question

This is my code.

n1, n2 = (int(input("Enter number: ")) for _ in range(2))
print("Select Your Choice: ")
print(" 1: Addition",
       "2: Substraction",
       "3: Multiplication",
       "4: Division")
choice = int(input())

switcher = {
        1: "Addition",
        2: "Substraction",
        3: "Multiplication",
        4: "Division",
    }
def addition(n1,n2):
    n1 += n2
    return n1

def substraction(n1,n2):
    n1 -= n2
    return n1

def multiplication(n1,n2):
    n1 *= n2
    return n1

def division(n1,n2):
    n1 /= n2
    return n1

def calculator(choice,n1,n2):
    return switcher.get(choice,"Invalid")(n1,n2)

print(calculator(choice,n1,n2))

I got below error.

> Traceback (most recent call last):   
> simple calculator with dictionary.py", line 36, in <module>
> print(calculator(choice,n1,n2))   
> simple calculator with dictionary.py", line 34, in calculator

> > return switcher.get(choice,"Invalid")(n1,n2) 
> TypeError: 'str' object is not callable

Can anyone solve this error?

Please reformat the code, its hardly readable.

sushanth
– sushanth

2020-05-29 05:04:51 +00:00
Commented May 29, 2020 at 5:04 — sushanth
– sushanth, Commented May 29, 2020 at 5:04
Could you make it work?

timgeb
– timgeb

2020-05-29 07:16:52 +00:00
Commented May 29, 2020 at 7:16 — timgeb
– timgeb, Commented May 29, 2020 at 7:16

timgeb · Accepted Answer · 2020-05-29 05:10:49Z

3

The values in switcher have to be the functions you defined, not strings.

switcher = {
    1: addition,
    2: substraction,
    3: multiplication,
    4: division,
}

Put this initialization of switcher after the definition of your functions.

You'll still get the "string not callable" error for invalid inputs, because

"Invalid"(n1, n2)

is not a valid function call. Adjust calculator to do something else for invalid inputs.

edited May 29, 2020 at 5:10

answered May 29, 2020 at 5:08

timgeb

79.2k20 gold badges129 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Python TypeError - : 'str' object is not callable

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related