Click on div using jquery error

Question

I have this HTML:

<div class="divHolder">
   <a href="./"><img src="./images/image6.jpg"/></a>
</div>
<div class="divHolder">
   <a href="./IT.aspx"><img src="./images/image7.jpg"/></a>
</div>

In my JavaScript I have:

$('.divHolder').click(function () {

    var link = $(this).find("a").attr("href");

    if (link != null) {
         location.href = link;
    }
});

However, every time I click on a div, the href of the div is always the last one: for example in this case is: IT.aspx.

What did I do wrong?

Hmm. Works for me, apart from that link is of course never null. Have you tried alert ing link rather than immediately forwarding to it? I'm just wondering whether it's just that the default page, if that's the correct term, is IT.aspx and essentially in the first instance all you're doing is stripping the url down to the last directory which will then load the default page in that directory. — tjm
– tjm, Commented Jun 2, 2011 at 17:52

Matthew Nessworthy · Accepted Answer · 2011-06-02 17:51:47Z

1

A better way to do this would be the following

$('.divHolder:has(a)').click(function () {
  location.href = $(this).find("a").attr("href");
});

answered Jun 2, 2011 at 17:51

Matthew Nessworthy

1,42810 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

olidev Over a year ago

I find it strange, but I fixed this problem in my javascript. Thanks!

Collectives™ on Stack Overflow

Click on div using jquery error

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related