Laravel - Use conditions when selecting data using controllers

Question

I have the following controller where I try to select all the customers of a user (The ones with 'user_id' equal to the 'id' of the authenticated user). I know how to do it in the following way, but as you can see it is not very efficient since it selects more records than necessary.

public function index() // Http/Controllers/CustomerController.php:17
{
    $user_id = Auth::id(); // Get user ID

    $customers = Customer::all()->where('user_id', $user_id); // Select all users and then filter by ID

    return $this->showAll($customers, 200); // Return JSON response with response code
}

user8034901 · Accepted Answer · 2020-06-06 21:10:16Z

3

Change your $customers = Customer::all()->where('user_id', $user_id); to:

$customers = Customer::where('user_id', $user_id)->get();

https://laravel.com/docs/7.x/eloquent#retrieving-models

answered Jun 6, 2020 at 21:10

user8034901

Sign up to request clarification or add additional context in comments.

1 Comment

Brahim Khallota Over a year ago

Perfect, I forgot the get() when I tried it, I will accpt the answer when I can. Thanks

Collectives™ on Stack Overflow

Laravel - Use conditions when selecting data using controllers

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related