problem filling string[] with string-array from strings.xml

Question

EDIT: woah ... somehow i replaced this question with another one i was asking, glad there is this rollback feature

this specific question deals with the getter from my previous question

public class Impacts extends Activity implements View.OnClickListener
{
    boolean[] impactsb = new boolean[] {false, false, false, false, false, false, false, false}-
    public void onCreate (Bundle savedInstanceState)
    {
    super.onCreate(savedInstanceState)
...

    String getImpacts ()
    {
    String[] impactsn = new String[length];
    Resources myResources = this.getResources();
    impactsn = myResources.getStringArray(R.array.impacts);
    StringBuilder impactss = new StringBuilder();
    for (int i = 0; i < length; i ++)
        {
        if (impactsb[i])
            impactss.append(impactsn[i] + " | ");
        }
    if (String.valueOf(impactss) != "")
        impactss.insert(0, "Impacts: ");
    return String.valueOf(impactss);
    }

with these errors:

Impacts(ContextWrapper).getResources() line: 80
Impacts.getImpacts() line: 78

the final bracket of the below code:

@Override
public Resources getResources()
{
    return mBase.getResources();
}

and this line of code respectively:

impactsn = getResources().getStringArray(R.array.impacts);

here is my strings.xml (the relevent parts anyway)

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <string-array name="impacts">
        <item>GasOilChemical Pollutants</item>
        <item>Ghost Fishing</item>
        <item>Marsh Damage</item>
        <item>Navigational Hazard</item>
        <item>Shellfish Damage</item>
        <item>Waste Pollution</item>
        <item>Wildlife Entanglement</item>
        <item>Other</item>
    </string-array>
</resources>

i originally had the first item as:

<item>Gas/Oil/Chemical Pollutants</item>

but fixed that, hoping that would at least change the error if not fixing the problem. but nope, same error. any help would be vastly appreciated, im not terribly familiar with the use of array, especially getting resources for an array.

Logcat for exception:

06-05 23:02:30.792: ERROR/AndroidRuntime(3905): FATAL EXCEPTION: main
06-05 23:02:30.792: ERROR/AndroidRuntime(3905): java.lang.NullPointerException
06-05 23:02:30.792: ERROR/AndroidRuntime(3905): at android.content.ContextWrapper.getResources(ContextWrapper.java:80)
06-05 23:02:30.792: ERROR/AndroidRuntime(3905): at com.citsci.mardeb.Impacts.getImpacts(Impacts.java:79)

@hooraygradschool: Is the getImpacts() method part of an Activity or a helper class? — Squonk
– Squonk, Commented Jun 3, 2011 at 17:34
it is part of a class that extends the activity, i added that to the top in response to your comment. — dylan murphy
– dylan murphy, Commented Jun 3, 2011 at 17:41
@hooraygradschool: Ok, if it's a method of your Impacts Activity then why do you have an override for getResources()? Just using getResources() should work fine - try commenting out your overridden getResources() method. — Squonk
– Squonk, Commented Jun 3, 2011 at 17:48
oh no i see your confusion, the overide and that block go with the Impacts(ContextWrapper).getResources() line: 80 which is not part of my code, its part of the platform or source or whatever. sorry i didnt understand your questions/made an error in pasting the code to here. — dylan murphy
– dylan murphy, Commented Jun 3, 2011 at 18:23
@hooraygradschool: OK, I get it now - I can see that in the ContextWrapper source. Try separating your line of code into two in order to see what is causing the failure, i.e., Resources myResources = getResources(); impactsn = myResources.getStringArray(R.array.impacts); — Squonk
– Squonk, Commented Jun 3, 2011 at 18:31

dylan murphy · Accepted Answer · 2011-06-06 17:19:05Z

4

i know this is poor coding, apologies in advance. so to fix this problem, i moved

String[] impactsn;
impactsn = getResources().getStringArray(R.array.impacts);

to my main activity and made it static. now i refer to it within my Impacts class as (MainActivity).impactsn[]

i know this is not how you are supposed to share objects between classes, but it seems to be the easiest way so far. this is yet another reason why i am regretting my decision to make all of my tabs seperate activities. if you have any suggestions or advice on how to fix this code without using static references or on reasons why all of my tabs should be the same activities, please chime in.

answered Jun 6, 2011 at 17:19

dylan murphy

1,3701 gold badge18 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hgusein · Accepted Answer · 2011-08-12 15:54:18Z

1

suggest not to define an array in advance, and used directly without defining a variable

mAutoComplete.setAdapter (new ArrayAdapter<String>(this, android.R.layout.simple_dropdown_item_1line, getResources().getStringArray(R.array.OmskStreets)));

and more..

in Class

private String[] mStreets = null;

and in onCreate method

mStreets = getResources().getStringArray(R.array.OmskStreets);

edited Aug 12, 2011 at 15:54

answered Aug 10, 2011 at 14:04

hgusein

112 bronze badges

Comments

takrl · Accepted Answer · 2011-07-11 07:43:14Z

0

Shouldn't define anything about UI before onCreate().

Moreover, the following is a poor coding example, but it works.

public void onCreate(Bundle icicle){
     super.onCreate(icicle);
...
...
...
     COUNTRIES  = getResources().getStringArray(R.array.COUNTRIES_ARRAY);

edited Jul 11, 2011 at 7:43

takrl

6,5003 gold badges63 silver badges71 bronze badges

answered Jul 11, 2011 at 5:57

Tony LO.

131 silver badge4 bronze badges

1 Comment

dylan murphy Over a year ago

super.onCreate(bundle) was within the ellipses in my code. i have added it so it is apparent. im not sure what this answer adds to my question.

Collectives™ on Stack Overflow

problem filling string[] with string-array from strings.xml

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related