C# Adding to list issue

Question

Hey guys, I have an application which consists of a baseclass (MacroCommand), three subclasses of MacroCommand (Resize, Rotate, Colour), and another class which does not inherit anything (Image) and then another class (Macro) which holds a list of MacroCommands

class Macro
{
    List<MacroCommand> macroCommandList = new List<MacroCommand>();
}

Basically, when I create my MacroCommand objects in the Form class, I need to then add them to the MacroCommand list, however, I keep getting errors when I try to do this:

macroCommandList.Add(colourObject);
macroCommandList.Add(rotateFlipObject);
macroCommandList.Add(resizeObject);

(this is in the Form class)

Any help would be appreciated, thanks guys.

EDIT: Errors:

Error 2 The name 'colourObject' does not exist in the current context C:\Users\Ari\Desktop\Assignment 3\Assignment 3\Assignment 3\Form1.cs 134 42 Assignment 3 Error 3 The name 'macroCommandList' does not exist in the current context C:\Users\Ari\Desktop\Assignment 3\Assignment 3\Assignment 3\Form1.cs 135 21 Assignment 3

It's just these errors but for each different line

I think you will need to post the complete code in order to get proper help. — Pablo Santa Cruz
– Pablo Santa Cruz, Commented Jun 5, 2011 at 12:19
What are the types of colourObject, rotateFlipObject, and resizeObject? — Yuck
– Yuck, Commented Jun 5, 2011 at 12:20
You can only do macroCommandList.Add inside the Macro class, since you're accessing a private member. — CodesInChaos
– CodesInChaos, Commented Jun 5, 2011 at 12:23

Pablo Santa Cruz · Accepted Answer · 2011-06-05 12:21:00Z

1

This should work:

class Macro {
    private List<MacroCommand> macroCommandList = new List<MacroCommand>();

    public void AddMacroCommand(MacroCommand mc)
    {
        macroCommandList.Add(mc);
    }
}

answered Jun 5, 2011 at 12:21

Pablo Santa Cruz

182k33 gold badges250 silver badges300 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David · Accepted Answer · 2011-06-05 12:37:50Z

0

According to the error, the objects you're trying to add don't exist. Where are those objects declared? What is their scope? The list is private by default, so you need to supply those objects as arguments to the method which is adding them to the list.

answered Jun 5, 2011 at 12:37

David

221k42 gold badges245 silver badges337 bronze badges

Comments

Andrei · Accepted Answer · 2011-06-05 12:39:31Z

0

If you have a List<BaseClass> you can only add to it elements that can be converted to the BaseClass (i.e. BaseClass'es and classes derived from BaseClass).

If you want to add elements to a list (say, macroCommandList ) you need to make sure the list is accesible to the calling code. This means either making it public (not a very good idea) or adding a public method to its containig class (i.e. Macro) that does the adding. The method is public so it is accessible to callers outside the class and it also has access to the private variable macroCommandList.

answered Jun 5, 2011 at 12:39

Andrei

5,04325 silver badges30 bronze badges

Collectives™ on Stack Overflow

C# Adding to list issue

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related