Javascript function with 2 arguments

Question

I need to create a function with 2 arguments (price1, price2), which should be added together and the result would be displayed in a text field after adding Vat to them.

Overall, I need to have 3 text fields: price1, price2 and results. In addition, the results field should be calculated after pushing the button calculate.

So far, I've come up with a return function with document.write, but it obviously doesn't display any text fields, which looks like that:

function getTotalPrice(price1,price2,Vat)
{
  var sum=price1+priceb;
  var Vat=20;
  return ((sum*Vat)*100)/100;
}
document.write(getTotalPrice(4,3));

I have no clue how to create the button that could calculate Vat and display it in the third text box.

Why do you have a third (unused) Vat variable in the function parameters? — Oded
– Oded, Commented Jun 5, 2011 at 18:35
Thank you for pointing out, indeed, this one is also not working. — epsilon
– epsilon, Commented Jun 5, 2011 at 18:44
@Oded, optional parameters are technically fine. My question is not just why it was unused, but why Vat was redeclared inside the function, as it will then never take on any value except 20. — brymck
– brymck, Commented Jun 5, 2011 at 18:45

PAG · Accepted Answer · 2011-06-05 18:49:27Z

3

Buttons are created with the input tag. An example that does what you want:

<input type="text" id="price1">
<input type="text" id="price2">
<input type="text" id="results">
<input type="button" value="Calculate" onclick="calculateResults()">

<script type="text/javascript">
function calculateResults() {
    var price1Box = document.getElementById('price1');
    var price2Box = document.getElementById('price2');
    var resultsBox = document.getElementById('results');
    resultsBox.value = getTotalPrice(price1Box.value, price2Box.value);
}
</script>

There are cleaner ways to do this, but this is the most practical and simplest. You'll need the fixes posted by Bryan if you want getTotalPrice to work.

edited Jun 5, 2011 at 18:49

answered Jun 5, 2011 at 18:43

PAG

1,9561 gold badge18 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2014-08-10 05:09:36Z

1

Issues:

Vat is unused as an argument, and even if it were used it would always be reinitialized in your code and assigned a value of 20.
priceb was a typo.

Beyond that the code doesn't seem to have any evident problems.

function getTotalPrice(price1, price2, vat) {
  vat = (vat === undefined? 20 : vat); // give vat a default value if empty
  return (price1 + price2) * vat;
}

document.write(getTotalPrice(4, 3));

Edit: Per the comment below, which is true, I figured I should just go ahead and simplify the math here. If the asker has a different equation in mind he should probably explain a bit more.

Edit: (vat === undefined? 20 : vat) is correct, producing any value other than undefined, default 20. (vat === undefined? vat : 20) will only produce undefined or 20.

edited Aug 10, 2014 at 5:09

CommunityBot

11 silver badge

answered Jun 5, 2011 at 18:42

brymck

7,66330 silver badges31 bronze badges

2 Comments

PAG Over a year ago

Unless I'm particularly mistaken, no one seems to have noticed that ((sum * vat) * 100) / 100 == sum * vat. What I think was intended was (sum * ((100 + vat) / 100)).

brymck Over a year ago

@PAG, true. I simplified things above.

Ant · Accepted Answer · 2011-06-05 18:49:14Z

0

This should do what you're after:

<script type="text/javascript">
  function getTotalPrice(price1,price2)
  {
    var vat = 20;
    return (((price1+price2) * vat) * 100) / 100;
  }

  function calculate()
  {
    var result = document.getElementById('result');
    result.value = getTotalPrice(document.getElementById('price1').value, document.getElementById('price2').value);
  }
</script>

<form>
  <input type="text" id="price1" />
  <input type="text" id="price2" />
  <input type="text" id="result" />
  <input type="button" value="Calculate" onclick="calculate()" />
</form>

answered Jun 5, 2011 at 18:49

Ant

3,8671 gold badge17 silver badges14 bronze badges

1 Comment

epsilon Over a year ago

Thank you this is exactly what I was looking for. Sorry for the typos anyway, I'm working on this code for some time (you're probably laughing now), and these bits are in the end the cleanest picture of what I am actually trying to do. Thank you very much again!

Collectives™ on Stack Overflow

Javascript function with 2 arguments

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related