Javascript copy array. Changes affect both arrays

Question

I'm trying to copy an 2d array, but every time I change the value of the copied array, it changes the original one too.

Original Array

 board = [
        [0,1,0],
        [0,0,1],
        [1,1,1],
        [0,0,0]
      ];

let ans = board.slice();
    
    for(let i=0; i<board.length; i++){
        for(let j=0; j<board[i].length; j++){
            let neighbors = checkCell(board, i, j);
            if(board[i][j] === 1) {
                ans[i][j] = (neighbors === 2 || neighbors === 3 ? 1 : 0);
            } else {
                ans[i][j] = (neighbors === 3 ? 1 : 0);
            }
        }
    }

checkCell() is just a method which returns 1 or 0. My problem is that when I set a value to ans, it also changes the original board array. I tried to copy using and = [...board]; and got the same problem.

Check this out stackoverflow.com/questions/45949241/…

ABGR
– ABGR

2020-06-29 15:05:03 +00:00
Commented Jun 29, 2020 at 15:05 — ABGR
– ABGR, Commented Jun 29, 2020 at 15:05

Aplet123 · Accepted Answer · 2020-06-29 15:03:46Z

3

When you copy via .slice or [...] it performs a shallow copy, which means the outer array is copied but the inner arrays aren't. You can individually copy each element:

let ans = board.map(v => v.slice()); // copies every 1d array

answered Jun 29, 2020 at 15:03

Aplet123

35.8k1 gold badge41 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Aman-D · Accepted Answer · 2020-06-29 15:19:17Z

1

This is happening because the slice() method returns a shallow copy of elements and the way elements are copied is using the references, i.e. both the original and new array refer to the same object. If a referenced object changes, the changes are visible to both the new and original arrays.

Use slice only when you want a shallow copy of the parent array to produce some other outputs.

You can read more here

answered Jun 29, 2020 at 15:19

Aman-D

713 bronze badges

Collectives™ on Stack Overflow

Javascript copy array. Changes affect both arrays

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related