how to take multiple strings as input and store them in a 2d array using c?

Question

The following is my code written in c language where I am trying to take strings as input and store them in a 2d array.

#include<stdio.h>
#include<stdlib.h>
#include<string.h>
int main(){
    int i,j,n;
    scanf("%d",&n);
    char a[n][n];
    for(i=0;i<n;i++){
        scanf(" %[^\n]",a[i]);
    }
    for(i=0;i<n;i++){
        printf("%s\n",a[i]);
    }
}

below is my input
4
1112
1912
1892
1234

my excepted output should look like below
1112
1912
1892
1234

the output which I am getting is below
1112191218921234
191218921234
18921234
1234

can anyone explain what is wrong in my code? any help would be appreciated! thanks:)

Hint: an array of length 4 cannot hold a string of length 4, the space for nul-terminator is not there. — Sourav Ghosh
– Sourav Ghosh, Commented Jun 29, 2020 at 15:18
Also, beware while using array as strings, they need null-termination to work. — Sourav Ghosh
– Sourav Ghosh, Commented Jun 29, 2020 at 15:20

Rohan Bari · Accepted Answer · 2020-06-30 17:02:56Z

1

You need to change:

char a[n][n];

Into:

char a[n][n + 1];

For a null-terminator. Without that, the char array won't be terminated and keep printing.

You'll get the correct output afterwards:

$ gcc -o prog prog.c; ./prog
4
1112
1912
1892
1234

edited Jun 30, 2020 at 17:02

answered Jun 29, 2020 at 15:20

Rohan Bari

7,7393 gold badges18 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Sourav Ghosh Over a year ago

and the outer dimension can very well stay as n.

Luis Colorado Over a year ago

@RohanBari, then better to delete these comments. Mine already erased.

Collectives™ on Stack Overflow

how to take multiple strings as input and store them in a 2d array using c?

1 Answer 1

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related