Dynamically (programatically) adding check boxes and checkedchanged events

Question

I am having a bit of a problem adding a few check boxes and an event handler programatically. The check boxes all appear fine, but they don't do anything when clicked. Does anyone have any idea what I am doing wrong?

My code:

foreach (Statement i in theseStatements)
{
    box = new CheckBox();
    box.Text = i.StatementText;
    box.AutoPostBack = true;
    box.CheckedChanged += new EventHandler(this.CheckedChange);
    PlaceHolder.Controls.Add(box);
}

protected void CheckedChange(object sender, EventArgs e) 
{
    CheckBox x = (CheckBox)sender;
    Instructions.Text = "change";            
    WorkPlaceHazardsBox.Text += x.Text;
}

What's "Instructions", and what's "WorkPlaceHazardsBox"? (the part of the code you show us seems fine) — Brann
– Brann, Commented Mar 9, 2009 at 16:08
Instructions is a label at the top of the page and WorkPlaceHazardsBox is a multiline text box in the middle of the page — Comanighttrain
– Comanighttrain, Commented Mar 9, 2009 at 16:18

Ken Browning · Accepted Answer · 2009-03-09 16:10:53Z

3

You should do the following:

Set the ID property for each instance of CheckBox you create in your foreach loop.
For PostBacks, ensure that your CheckBoxes are created and CheckedChanged event handler is attached at some point of the page life-cycle before control events are raised

answered Mar 9, 2009 at 16:10

Ken Browning

29.1k6 gold badges58 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Comanighttrain Over a year ago

Yup, my CheckBoxes were being eaten during postback

eglasius · Accepted Answer · 2009-03-09 16:45:03Z

2

Make sure to verify you are doing the following:

The same list of checkbox is being added on both the initial load and further postbacks
You set a different ID to each checkbox
Verify you are getting a postback (set a break point in Page Load)
The controls are added to the page on Page Load, or even better on Page Init

If you are trying to do something different than that, update us with more info.

answered Mar 9, 2009 at 16:45

eglasius

35.9k5 gold badges69 silver badges110 bronze badges

Comments

casperOne · Accepted Answer · 2009-03-09 16:08:25Z

0

If you have one Instructions textbox and one WorkPlaceHazards textbox per checkbox, then you have to have a way to associate the checkbox that was clicked with those other two controls.

If that's not the case, then what are they supposed to be doing?

answered Mar 9, 2009 at 16:08

casperOne

74.7k19 gold badges189 silver badges262 bronze badges

Comments

Jon Skeet · Accepted Answer · 2009-03-09 16:09:09Z

0

When you say they "don't do anything" - are you getting the postback?

I wouldn't be surprised if you had to assign IDs to the checkboxes - bear in mind that on the postback, you'll get a new page, so it'll have to recreate all the checkboxes, then work out which one was checked etc. This is getting into what is (to me, anyway) somewhat black magic side of ASP.NET. I think you'll have to study the page life cycle and control identification side of things reasonably carefully.

answered Mar 9, 2009 at 16:09

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Comments

mustafaozcan · Accepted Answer · 2009-03-09 21:53:35Z

0

You can get value by Request["controlname"] method when you inserted control in runtime.You must set Unique ID for each control.

However you can use CheckBoxList as an alternative instead of dynamically added checkboxes

answered Mar 9, 2009 at 21:53

mustafaozcan

Comments

Aaron Daniels · Accepted Answer · 2009-03-09 23:37:27Z

I copied your code into a new VS2005 C# web project (see below). Your code works. There may be something else going on outside of this snippet. Or, is the StatementText property in all of your statements collection always empty?

Page...

<body>
    <form id="form1" runat="server">
    <div>
        <asp:PlaceHolder ID="PlaceHolder1" runat="server"></asp:PlaceHolder>
        Instructions: <asp:TextBox ID="Instructions" runat="server" />
        WorkPlaceHazardsBox: <asp:TextBox ID="WorkPlaceHazardsBox" runat="server" />
    </div>
    </form>

</body>

Code behind...

using System;
using System.Data;
using System.Configuration;
using System.Collections.Generic;
using System.Web;
using System.Web.Security;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Web.UI.WebControls.WebParts;
using System.Web.UI.HtmlControls;

namespace CheckboxMadness
{
    public partial class _Default : System.Web.UI.Page
    {
        protected void Page_Load(object sender, EventArgs e)
        {
            List<string> statements = new List<string>(new string[] { "foo", "bar" });

            foreach (string i in statements)
            {
                CheckBox box = new CheckBox();
                box.Text = i;
                box.AutoPostBack = true;
                box.CheckedChanged += new EventHandler(this.CheckedChange);
                PlaceHolder1.Controls.Add(box);
            }

        }
        protected void CheckedChange(object sender, EventArgs e)
        {
            CheckBox x = (CheckBox)sender;

            Instructions.Text = "change";

            WorkPlaceHazardsBox.Text += x.Text;
        }
    }
}

zx485 · Accepted Answer · 2017-01-20 00:23:32Z

0

CheckedChanged may not work if embedded in another control, e.g. embedded in TableCells. Have a try to create a CheckBox and add CheckedChanged before creating an outer control (e.g. Table is outer control if CheckBox is embedded in Table's cells).

It could fix the problem in some cases.

edited Jan 20, 2017 at 0:23

zx485

29.1k28 gold badges55 silver badges65 bronze badges

answered Jan 19, 2017 at 23:27

xcx

1

Comments

GEOCHET · Accepted Answer · 2009-03-09 16:13:59Z

-1

var box = new CheckBox();

edited Mar 9, 2009 at 16:13

GEOCHET

21.3k15 gold badges78 silver badges99 bronze badges

answered Mar 9, 2009 at 16:08

Chris Holmes

11.6k12 gold badges53 silver badges64 bronze badges

Collectives™ on Stack Overflow

Dynamically (programatically) adding check boxes and checkedchanged events

My code:

8 Answers 8

1 Comment

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

My code:

8 Answers 8

1 Comment

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related