PHP including HTML in readfile

Question

I have the following code which kind of works but for some reason the $download includes the part inside into the downloaded file.

<form method="post">
<button id="click" name="click">Download</button>
</form>

<?php
if(isset($_POST['click'])){
$files = scandir('/local/path', SCANDIR_SORT_DESCENDING);
$newest_file = $files[0];
$download = $newest_file;

header("Content-Type: text/plain");
header('Content-Disposition: attachment; filename="'.$download.'"');
readfile("/local/path/$download");
}
?>

Downloaded file

form method="post">
<button id="click" name="click">Download</button>
</form>

Start-of-the-actual-log
blabla
blabla
blabla

What is causing this to happen? I only want to download the newest file in a folder.

In your code, you specifically output that HTML at the top of the script. — Nigel Ren
– Nigel Ren, Commented Jul 10, 2020 at 8:51
@NigelRen I'm sorry, I'm pretty much a noob. My understanding of the code is that it scans the local path and then grabs the file. I'm not sure how it is including the HTML part. — sjaak
– sjaak, Commented Jul 10, 2020 at 8:58

Benjamin Poignant · Accepted Answer · 2020-07-10 09:24:04Z

1

Dont print anything or send header before downloading, look at this :

<?php
if(isset($_POST['click'])){
    $files = scandir('/local/path', SCANDIR_SORT_DESCENDING);
    $newest_file = $files[0];
    $download = $newest_file;

    header("Content-Type: text/plain");
    header('Content-Disposition: attachment; filename="'.$download.'"');
    readfile("/local/path/$download");
}else{
     echo'
     <form method="post">
         <button id="click" name="click">Download</button>
     </form>';
}
?>

answered Jul 10, 2020 at 9:24

Benjamin Poignant

1,0648 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

sjaak Over a year ago

Thanks. Putting the code (without the else statement) serves just the file. But I still don't understand why the HTML gets included in the download to being with.

Collectives™ on Stack Overflow

PHP including HTML in readfile

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related