How to break index array in loop and use in php

Question

I have two values(bookingId) in index array and now i want to update query using these values but right now unable break array in loop, I want to run update query (according to count values in array) Here is my code,Where i am wrong ?

$bookingIds; // contaning two values 176,190
$counts = count($bookingIds);  // counting array values
for ($x = 1; $x <= $counts; $x++) 
    {
        $data = array('approved' => "1");
        $this->db->where('bookingId', $bookingIds);
        $this->db->update('notifications', $data);
    }

Kunal Raut · Accepted Answer · 2020-07-11 05:03:07Z

2

I think you should mention an index for your array while looping.And your $x must start with 0

$bookingIds; // contaning two values 176,190
$counts = count($bookingIds);  // counting array values
for ($x = 0; $x < $counts; $x++) 
    {
        $data = array('approved' => "1");
        $this->db->where('bookingId', $bookingIds[$x]);
        $this->db->update('notifications', $data);
    }

edited Jul 11, 2020 at 5:03

answered Jul 11, 2020 at 4:56

Kunal Raut

2,6042 gold badges14 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

GetSet Over a year ago

I thought you were more correct when you suggested using Base 0 for the index and the array.

Kunal Raut Over a year ago

@GetSet i thought it too but then i looked at the condition btw can you help me if i'm wrong?

GetSet Over a year ago

You're likely right. $bookingIds would most probably already be Base 0 since OP relies on count() which would be the Base 1 total of that.

Kunal Raut Over a year ago

Thanks @GetSet now i have changed the condition so that it is better for OP to understand as well thanks for your reply though 😊

GetSet Over a year ago

No prob. I just hope OP realizes or understands that in going to Base 0, the <= would be a logical error.

TimBrownlaw · Accepted Answer · 2020-07-11 05:16:09Z

1

One refactoring of the above using foreach to remove the whole indexing issue would be

$data = array('approved' => "1");
foreach ($bookingsIds as $bookingId )
{
    $this->db->where('bookingId', $bookingId);
    $this->db->update('notifications', $data);
}

answered Jul 11, 2020 at 5:16

TimBrownlaw

5,5373 gold badges27 silver badges29 bronze badges

Comments

Gras Double · Accepted Answer · 2020-07-11 07:13:52Z

0

Looks like you are using a framework; if it provides a whereIn() method, it would be more efficient to use it (runs less SQL queries):

$data = ['approved' => '1'];
$this->db
    ->whereIn('bookingId', $bookingIds)
    ->update('notifications', $data);

(Just be aware you can't put thousands and thousands of values in such a "where in" clause, because the query would be huge. Personally I process this kind of stuff in chunks, like 500 records per query.)

(Also, make sure no error happens if the "where in" array (here, $bookingIds) is empty. It's a special case, that the framework has to handle properly.)

edited Jul 11, 2020 at 7:13

answered Jul 11, 2020 at 7:07

Gras Double

16.5k9 gold badges61 silver badges56 bronze badges

Collectives™ on Stack Overflow

How to break index array in loop and use in php

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related