Split string using elements of array JavaScript

Question

Hello i'm working on dynamic search for my first web application and i have a huge problem i've been working on this for several hours using diffrent solutions in the end i think this might be the closest to resolving my problems.

Search is not static so hard coding this is not an option.

const search = 'someone loves some thing';
const teams = ['some thing', 'someone', 'help'];
const twoTeams = [];

if (teams.some(el => search.includes(el))) {
  teams.forEach(word => {
    if (search.includes(word)) {
      twoTeams.push(word);
    }
  })
}
console.log(twoTeams); // ['some thing','someone']
console.log(search) // 'someone loves some thing'
// looking for // console.log(twoTeams)// 'someone','some thing'

And here im stuck i have array of items that i need to split string with to access data from API i just need it in that order i cant reverse order because in the app theres too many elements in array and user can search anything so you dont know which one should will be index[0] and which one should be index[1] and thats crucial to my dynamic search.

@KarlL im looking for if search is 'someone loves some thing' output has to be : 'someone','some thing' — Patricios
– Patricios, Commented Jul 15, 2020 at 6:20

mcjmzn · Accepted Answer · 2020-07-15 06:27:20Z

2

First of all, I'd start with removing the outer if as we check every word anyway in the inner condition.

teams.forEach(word => {
    // Get the position of word in the search text. Negative value means that there is no match.
    let index = search.indexOf(word);

    // If the search text contains the word
    if (index >= 0) {
        // Save both the matching word and its index
        twoTeams.push( { 'word': word, 'index': index});
    }
})

// Sort the results by the index and select the word only
twoTeams = results.sort((a,b)=> a.index - b.index).map(result => result.word);

answered Jul 15, 2020 at 6:27

mcjmzn

3537 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Patricios Over a year ago

Thank you for your time, been working on this for 9 hours i had no idea that sort method exist, your answer was incredibly helpful.

Karan Over a year ago

This answer would be more efficient than mine. It would find in search only once. +1.

Karan · Accepted Answer · 2020-07-15 06:53:16Z

0

You can simplify your code to built twoTeams object with filter like below.

const twoTeams = teams.filter(el => search.includes(el));

As you want preserve order then you can sort your results with indexOf like below.

twoTeams.sort((a, b) => search.indexOf(a) - search.indexOf(b));

Try it below.

const search = 'someone loves some thing';
const teams = ['some thing', 'someone', 'help'];
const twoTeams = teams.filter(el => search.includes(el));
twoTeams.sort((a, b) => search.indexOf(a) - search.indexOf(b));

console.log(twoTeams); // looking for ['someone', 'some thing']
console.log(search) // 'someone loves some thing'

answered Jul 15, 2020 at 6:53

Karan

12.7k3 gold badges31 silver badges45 bronze badges

1 Comment

Patricios Over a year ago

Yeah, i overcomplicated that a bit :D, lost track after several hour's this is a great and clever answer. It's just mad that that i spend whole night trying to resolve this and i was 4 lines of code. Thank you for help !!!

Collectives™ on Stack Overflow

Split string using elements of array JavaScript

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related