update nested object in array Mongoose

Question

I would like the nested object with the id 5f0e14241f5ccb42d8742767 to be updated:

 {
        "_id": "5f0b33ab52a4e966c754d963",
        "make": "Toyota",
        "model": "Prius",
        "engine": "1.8",
        "insurances": [
            {
                "yearlyPremium": {
                    "$numberDecimal": "60.39"
                },
                "_id": "5f0e14241f5ccb42d8742767",
                "startDate": "1970-01-19T09:31:15.550Z",
                "monthlyPremium": {
                    "$numberDecimal": "5.49"
                },
                "excess": 100
            },
            {
                "yearlyPremium": {
                    "$numberDecimal": "71.39"
                },
                "_id": "5f0e147c0340243eb03b5247",
                "startDate": "1970-01-19T09:31:15.550Z",
                "monthlyPremium": {
                    "$numberDecimal": "6.49"
                },
                "excess": 100
            },
       ]
 }

So in my PATCH rest api request, I just want to change the monthly premium, from what it is currently 5.49 to 1.50. Hence I pass the carId: 5f0b33ab52a4e966c754d963 and the particular inusranceId: 5f0e14241f5ccb42d8742767 (nested in Car object) as query params, to identify which insurance in the insurances array needs updating. Then in the request body I pass the item to be modified (monthlyPremium):

I followed the stack overflow solution: mongoDB: Update nested array object

So this is what I tried:

router.route('/insurance')
.patch(async (req, res) => {
    const { carId, insuranceId } = req.query
    const { startDate, monthlyPremium, excess } = req.body
    try {
        const foundCar = await Car.findById(carId)
        const foundCar = foundCar.insurances.filter(ins => {
            return ins._id == insuranceId
        })
        
        foundInsurance.startDate = startDate && new Date(startDate * 1000) || foundInsurance.startDate,
        foundInsurance.monthlyPremium = monthlyPremium && parseFloat(monthlyPremium) || foundInsurance.monthlyPremium,
        foundInsurance.yearlyPremium = monthlyPremium && parseFloat(monthlyPremium) * 12 || foundInsurance.yearlyPremium,
        foundInsurance.excess = excess && Number(excess) || foundInsurance.excess
        
        Car.update(
            {_id: carId, "insurances._id": insuranceId}, 
            {$set: {"insurances.$":foundInsurance}}
        )

        res.send(`Insurance updated`)
    } catch (err) {
        res.status(400).json({ error: err })
    }
})

The request queries are captured correctly in the code. The request succeeds and returns Insurance updated, but nothing gets updated. Everything is working except the update method is not updating the info monthlyPremium to 1.50.

UPDATE

@Mahan, I tried your suggested approach, unfortunately the record still hasn't changed. Printing foundInsurance I get this (it doesn't print the values in the console, just the meta data):

found insurance: {
  yearlyPremium: Decimal128 {
    _bsontype: 'Decimal128',
    bytes: <Buffer 97 17 00 00 00 00 00 00 00 00 00 00 00 00 3c 30>
  },
  _id: 5f0e14241f5ccb42d8742767,
  startDate: 1970-01-19T09:31:15.550Z,
  monthlyPremium: Decimal128 {
    _bsontype: 'Decimal128',
    bytes: <Buffer 25 02 00 00 00 00 00 00 00 00 00 00 00 00 3c 30>
  },
  excess: 100
}

MahanTp · Accepted Answer · 2020-07-15 14:46:31Z

1

Please try using mongoose arrayFilters like this:

Car.update(
  { _id: carId }, 
  { $set: { "insurances.$[elem]": foundInsurance } },
  { arrayFilters: [ { 'elem._id': insuranceId } ] }
)

answered Jul 15, 2020 at 14:46

MahanTp

7446 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

14 Comments

Hazzaldo Over a year ago

Thanks Mahan. Actually now I'm getting an error on POSTMAN for that endpoint.

{     "error": {         "stringValue": "\"insurance\"",         "kind": "ObjectId",         "value": "insurance",         "path": "_id",         "reason": {}     } }

Not sure why. It's the same setup you see in the screenshot in my question for POSTMAN

MahanTp Over a year ago

Would you please post your foundInsurance object ? After you set its properties.

Hazzaldo Over a year ago

Ok the problem right now is with the PATCH endpoint. Even if I empty the whole body of the call back (for the API) from any code, I'm still getting this error. So there must be an issue with the endpoint. I can't see where the issue is!!!

MahanTp Over a year ago

Do you set app.use(bodyParser.json()); middleware in your express app.js ?

MahanTp Over a year ago

And also app.use(bodyParser.urlencoded({extended: false}));

|

Collectives™ on Stack Overflow

update nested object in array Mongoose

1 Answer 1

14 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

14 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related