Get array of words from a string [duplicate]

Question

I am working on an requirement where I need to get all the words from a string into an array. A 'word' is described as any sequence of non-space charachters. There can be any number of whitespace charachters present in the string.

Input Examples :

"  Hello World!!  "
"Hello World!!"
"  Hello       World!!    "

In all above cases the output should be ["Hello","World!!"]

Now I have tried to solve the example myself and have below code :

public string[] GetWords(string s)
   {
        s=s.Trim();
        while(s.Contains("  "))
        {
            s = s.Replace("  ", " ");
        }

        string[] input=s.Split(' ');
        return input;
   }

I am getting correct result using the above code. My concerns is there any way the code can be made clean or more optimized than it currently is.

The definition of "clean" might be opinion-based. For "optimized", you also need to specify in which way: fast? small memory footprint? small code size? — dymanoid
– dymanoid, Commented Jul 15, 2020 at 14:08
string.Split(' ', StringSplitOptions.RemoveEmptyEntries) would be an idea — Homungus
– Homungus, Commented Jul 15, 2020 at 14:09
@dymanoid I was looking for result in less number of steps than I am performing. — Jasmeet
– Jasmeet, Commented Jul 15, 2020 at 14:11
Also without RegEx, to adapt: stackoverflow.com/questions/58734248/… — user12031933
– user12031933, Commented Jul 15, 2020 at 16:37

ScareCrow · Accepted Answer · 2020-07-15 15:26:21Z

2

Use the following code snippet:

var str = "  Hello World!!  ";
string[] array = str.Split(new Char[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);

The result will be ["Hello","World!!"]

Note: new Char[] { ' ' } if multiple characters need to be handled. Otherwise, you can use the following

string[] array = str.Split(' ', StringSplitOptions.RemoveEmptyEntries);

edited Jul 15, 2020 at 15:26

answered Jul 15, 2020 at 15:21

ScareCrow

5233 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MarTim · Accepted Answer · 2020-07-15 14:14:23Z

2

I would use a regular expression:

using System.Text.RegularExpressions;

...

public string[] GetWords(string s) =>
    Regex.Matches(s, @"[^\s]+")
        .Cast<Match>()
        .Select(x => x.Value)
        .ToArray();

answered Jul 15, 2020 at 14:14

MarTim

1487 bronze badges

1 Comment

Olivier Jacot-Descombes Over a year ago

I would use Regex.Split().

Collectives™ on Stack Overflow

Get array of words from a string [duplicate]

2 Answers 2

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Linked

Related