sys.exit(1) not working, the script ends with code 0

Question

I have the following code:

try:
    self._collect_persons_status()
except manager.AsteriskManagerError:
    # If it is not possible to continue with the collection of initial
    # person statuses via Asterisk Manager, end the program with an
    # error code.
    logger.debug('*** exit with 1!!')
    sys.exit(1)

This script is handled via systemd (runs as a daemon with a loop).

From the log I can see that *** exit with 1!! is printed, but the script ends with code 0, not 1 as expected:

What am I doing wrong?

Do you perhaps have try: <invoke script entry point> except: <log error> at the script top-level? — user4815162342
– user4815162342, Commented Jul 20, 2020 at 8:41
@user4815162342 oh yes, you're right! If you post this as an answer I'll give you the best check — lorenzo
– lorenzo, Commented Jul 20, 2020 at 8:45

user4815162342 · Accepted Answer · 2020-07-20 09:52:14Z

6

If you have something like this at script top-level, it will prevent sys.exit() from exiting the program:

try:
    <invoke script entry point>
except:
    <log the error>

This is because sys.exit() is implemented by raising the SystemExit exception. You can fix the code by changing except: to except Exception which won't catch SystemExit (and some other low-level exceptions that you probably don't want to handle either).

edited Jul 20, 2020 at 9:52

answered Jul 20, 2020 at 8:48

user4815162342

159k22 gold badges350 silver badges418 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

timgeb Over a year ago

I would use except Exception, which will not catch exiting exceptions.

user4815162342 Over a year ago

@timgeb Good idea; I've now amended the answer to recommend that instead of explicit except SystemExit.

Collectives™ on Stack Overflow

sys.exit(1) not working, the script ends with code 0

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related