Replace commas with Javascript

Question

I have strings (painting title, painter name) that have one or two commas, such as Big House, Jone Doe or Big House, Blue, John Doe. These are captions for the actual paintings. And I want to replace the correct comma with by.

I can get the captions with

const captions = document.querySelectorAll('#gallery .caption');
    for (const caption of captions) {
        var new_caption = caption.textContent.toString();

If I use replace(","," by"), that gets me the first comma. Then replace(",/g", " by") does it for both. How do I replace just the second comma if there is one? Can't figure this out. Thanks.

Expectations? just want to know how to replace the second comma, if there is one, with "by". — user42760
– user42760, Commented Jul 28, 2020 at 13:31
Possible duplicate of Match at every second occurrence. Use that in combination with replace. — Igor
– Igor, Commented Jul 28, 2020 at 13:31

T.J. Crowder · Accepted Answer · 2020-07-28 13:32:50Z

1

To replace only the last comma, you could use /,(?=[^,]*$)/, which looks for a comma and uses a lookahead assertion to ensure that it's only followed by text without a comma through the end of the string:

const rex = /,(?=[^,]*$)/;
test("Big House, Jone Doe");
test("Big House, Blue, John Doe");
test("Big House, Blue, with Tree, John Doe");

function test(str) {
    console.log(str, "=>", str.replace(rex, " by"));
}

answered Jul 28, 2020 at 13:32

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user42760 Over a year ago

Very nice solution, Thanks!

ˈvɔlə · Accepted Answer · 2020-07-28 13:37:22Z

0

For people who want to avoid regular expressions, you can define a replaceAt function:

String.prototype.replaceAt = function(index, replacement) {
    return this.substr(0, index) + replacement + this.substr(index + replacement.length);
}

Then, you can use lastIndexOf() to find out the last appearance of comma:

const captions = document.querySelectorAll('#gallery .caption');
    for (const caption of captions) {
        let indexOfLastComma = caption.textContent.lastIndexOf(',');
        let newCaption = caption.textContent.replaceAt(indexOfLastComma, ' by');
        caption.textContent = newCaption;
    }
}

answered Jul 28, 2020 at 13:37

ˈvɔlə

10.4k12 gold badges74 silver badges108 bronze badges

Comments

iAmOren · Accepted Answer · 2020-07-28 13:39:55Z

0

Try this:

var string="We don't need no education, The Wall, Pink Floyd";
var lastComma=string.lastIndexOf(",");
if(lastComma!=-1)
  string=string.slice(0,lastComma)+" by"+string.slice(lastComma+1);

Or, in a function:

function replaceLastCommaWithBy(string) {
  var lastComma=string.lastIndexOf(",");
  if(lastComma!=-1)
    string=string.slice(0,lastComma)+" by"+string.slice(lastComma+1);
  return string;
}

answered Jul 28, 2020 at 13:39

iAmOren

2,8122 gold badges14 silver badges23 bronze badges

Collectives™ on Stack Overflow

Replace commas with Javascript

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related